Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35708

Right align user's information in quiz attempt review page , when in RTL mode (theme/standard & base)

          Details

          • Type: Improvement
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.3, Future Dev
          • Fix Version/s: 2.2.6, 2.3.3
          • Component/s: Quiz
          • Labels:
          • Testing Instructions:
            Hide
            1. Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs)
            2. Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting)
            3. Navigate into any course
            4. As a Techer (or Admin), Add a Quiz.
            5. Add one or two questions to the Quiz (does not matter which, "Multiple Choose" are good)
            6. Switch to "Student" (Either by "switching role", if you are the Administrator, Or by using a predefined user with "Student" role in that specific course)
            7. Take the Quiz and make sure all the above UI errors do not show up
            8. After the Quiz is finished, run through the "Quiz review" to make sure it too looks OK.
            Show
            Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs) Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting) Navigate into any course As a Techer (or Admin), Add a Quiz. Add one or two questions to the Quiz (does not matter which, "Multiple Choose" are good) Switch to "Student" (Either by "switching role", if you are the Administrator, Or by using a predefined user with "Student" role in that specific course) Take the Quiz and make sure all the above UI errors do not show up After the Quiz is finished, run through the "Quiz review" to make sure it too looks OK.
          • Affected Branches:
            MOODLE_23_STABLE
          • Fixed Branches:
            MOODLE_22_STABLE, MOODLE_23_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            WIP-MDL-35708-master_quiz
          • Pull Master Diff URL:

            Description

            Right align user's information in quiz attempt review page , when in RTL mode (theme/standard & base)

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  lazydaisy Mary Evans added a comment -

                  @Tim
                  Any chance you could review the code here.
                  Thanks
                  Mary

                  Show
                  lazydaisy Mary Evans added a comment - @Tim Any chance you could review the code here. Thanks Mary
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  +1 from me. Thanks for fixing this Nadav.

                  Are you able to submit this for integration, or do you need one of us to do it? Will you cherry-pick to the stable branches first?

                  Show
                  timhunt Tim Hunt added a comment - +1 from me. Thanks for fixing this Nadav. Are you able to submit this for integration, or do you need one of us to do it? Will you cherry-pick to the stable branches first?
                  Hide
                  Permalink
                  nadavkav Nadav Kavalerchik added a comment -

                  Done

                  Show
                  nadavkav Nadav Kavalerchik added a comment - Done
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Submitting for integration.

                  Show
                  timhunt Tim Hunt added a comment - Submitting for integration.
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  Thanks Nadav, i've integrated this to 22, 23 and master.

                  Show
                  poltawski Dan Poltawski added a comment - Thanks Nadav, i've integrated this to 22, 23 and master.
                  Hide
                  Permalink
                  rwijaya Rossiani Wijaya added a comment - - edited

                  Hi Nadav,

                  The fixed works great on 2.2, 2.3 and 2.4.

                  However I noticed that on 2.2, the 'quiz navigation' is displayed on the left side. (screenshots)

                  I'm aware that the issue might not part of intended changes. Please let me know if you want to add a quick fix for this or create a new issue.

                  Thanks
                  Rosie

                  Show
                  rwijaya Rossiani Wijaya added a comment - - edited Hi Nadav, The fixed works great on 2.2, 2.3 and 2.4. However I noticed that on 2.2, the 'quiz navigation' is displayed on the left side. (screenshots) I'm aware that the issue might not part of intended changes. Please let me know if you want to add a quick fix for this or create a new issue. Thanks Rosie
                  Hide
                  Permalink
                  rwijaya Rossiani Wijaya added a comment -

                  I'm passing this issue and creating MDL-35772 to fix the 'quiz navigation' display.

                  Test passed.

                  Show
                  rwijaya Rossiani Wijaya added a comment - I'm passing this issue and creating MDL-35772 to fix the 'quiz navigation' display. Test passed.
                  Hide
                  Permalink
                  nadavkav Nadav Kavalerchik added a comment -

                  Thanks
                  I will fix MDL-35772

                  Show
                  nadavkav Nadav Kavalerchik added a comment - Thanks I will fix MDL-35772
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Closing as fixed, many thanks for your awesome collaboration.

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your awesome collaboration.

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        12/Nov/12