Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35710

mod_assign: assessable_content_done event name is not precise

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      The plariarism API is not currently testable so this minimal test will suffice.

      1. Create an assignment with "Require students click submit button" set to true and "Online Text" submissions enabled
      2. Login as a student and add some text to your submission
      3. "Submit" the assignment
      4. Verify there are no errors reported on the page
      Show
      The plariarism API is not currently testable so this minimal test will suffice. Create an assignment with "Require students click submit button" set to true and "Online Text" submissions enabled Login as a student and add some text to your submission "Submit" the assignment Verify there are no errors reported on the page
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      The event 'assessable_content_done' triggered on assignment submission (mod_assign)

      • does not have a clear name that would hint what it does
      • Inconsistent with naming of content and file upload events (assessable_content_uploaded, assessable_file_uploaded events). assessable_content_done is called on any type of assignment submission (content, file and any other found in submission sub-directory), not for the "content" submission type only.

      Therefore it should be renamed to something clear and independent of submission type.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12