Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35723

Align to center the "Quiz Feedback" label,when in RTL mode

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3.2, 2.4
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs)
      2. Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting)
      3. Navigate into any course
      4. As a teacher, Setup a Quiz including a question or two and set it up for multiple attempts!
      5. Switch to Student
      6. Take two attempts at answering the quiz
      7. Now, Check that the new CSS fixes things, as per the screen-grabs.
        ( Home / ► My courses / ► Test Course ► Topic 1 / ► Some test Quiz / ► Info )
      Show
      Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs) Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting) Navigate into any course As a teacher, Setup a Quiz including a question or two and set it up for multiple attempts ! Switch to Student Take two attempts at answering the quiz Now, Check that the new CSS fixes things, as per the screen-grabs. ( Home / ► My courses / ► Test Course ► Topic 1 / ► Some test Quiz / ► Info )
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      WIP-MDL-35723-master_quiz

      Description

      Align to center the "Quiz Feedback" label,when in RTL mode

      I know that in English it is aligned to the left and you are probably thinking...
      It should be aligned to the right, in RTL mode. BUT, I think it is better on the center.
      If you accept it... You might consider changing the original (LTR) CSS rule to
      text-align:center; and discard the RTL patch.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            I actually think it should be right aligned, like the quiz introduction. Some quizzes use a few paragraphs of feedback.

            Show
            timhunt Tim Hunt added a comment - I actually think it should be right aligned, like the quiz introduction. Some quizzes use a few paragraphs of feedback.
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            You are right, but...
            I am suggesting to align the Title label of the feedback and not the feedback itself.

            Show
            nadavkav Nadav Kavalerchik added a comment - You are right, but... I am suggesting to align the Title label of the feedback and not the feedback itself.
            Hide
            timhunt Tim Hunt added a comment -

            Well, in LTR languages, title is centred, main text is left-aligned.

            In the end, I am happy for a RTL user to decide what happens in RTL languages, so I will let you decide. You are welcome to submit a patch for integration with either text-align: center; or text-align: right;

            Show
            timhunt Tim Hunt added a comment - Well, in LTR languages, title is centred, main text is left-aligned. In the end, I am happy for a RTL user to decide what happens in RTL languages, so I will let you decide. You are welcome to submit a patch for integration with either text-align: center; or text-align: right;
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Thanks.
            I agree with the "LTR languages, title is centred, main text is left-aligned."
            I would like the opposite for RTL
            "LTR languages, title is centred, main text is right-aligned."

            It seems the title is not centered in LTR mode (I see it in the code and on the screen)
            If you fix it in the code, I will discard the proposed fix

            Show
            nadavkav Nadav Kavalerchik added a comment - Thanks. I agree with the "LTR languages, title is centred, main text is left-aligned." I would like the opposite for RTL "LTR languages, title is centred, main text is right -aligned." It seems the title is not centered in LTR mode (I see it in the code and on the screen) If you fix it in the code, I will discard the proposed fix
            Hide
            timhunt Tim Hunt added a comment -

            I don't know. I am not going to change the LTR layout, because no-one has complained, although perhaps the should be. The layout is a bit weird.

            Show
            timhunt Tim Hunt added a comment - I don't know. I am not going to change the LTR layout, because no-one has complained, although perhaps the should be. The layout is a bit weird.
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Ok.
            I will go with the RTL fix.

            Show
            nadavkav Nadav Kavalerchik added a comment - Ok. I will go with the RTL fix.
            Hide
            timhunt Tim Hunt added a comment -

            Right. When there are stable branches containing your preferred fix, I will submit them for integration.

            Show
            timhunt Tim Hunt added a comment - Right. When there are stable branches containing your preferred fix, I will submit them for integration.
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Done

            Show
            nadavkav Nadav Kavalerchik added a comment - Done
            Hide
            timhunt Tim Hunt added a comment -

            Thanks, Nadav. Submitting for integration.

            Show
            timhunt Tim Hunt added a comment - Thanks, Nadav. Submitting for integration.
            Hide
            nebgor Aparup Banerjee added a comment -

            thanks, integrated.

            ps: please provide page titel in test instructions to save tester looking up either the translation or looking at patch :-D

            Show
            nebgor Aparup Banerjee added a comment - thanks, integrated. ps: please provide page titel in test instructions to save tester looking up either the translation or looking at patch :-D
            Hide
            dmonllao David Monllaó added a comment -

            It passes, tested in 22 and master, the text appears centered

            Show
            dmonllao David Monllaó added a comment - It passes, tested in 22 and master, the text appears centered
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            From somewhere within the clouds...

            Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12