Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35724

Right align "Question Type" label in Quiz Editing page, when in RTL mode

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3.2, 2.4
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. Install an Hebrew (RTL) language pack, and switch to Hebrew
      2. As Admin or a Teacher, navigate into a course containing a Quiz with some questions
      3. Click the Quiz to view it
      4. Click "Edit Quiz" (From the Settings Block) to see the Question list
      5. See the issues described above (You can switch to LTR mode for reference by adding "&lang=en" to the URL)
      Show
      Install an Hebrew (RTL) language pack, and switch to Hebrew As Admin or a Teacher, navigate into a course containing a Quiz with some questions Click the Quiz to view it Click "Edit Quiz" (From the Settings Block) to see the Question list See the issues described above (You can switch to LTR mode for reference by adding "&lang=en" to the URL)
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      WIP-MDL-35724-master_quiz

      Description

      Question type element is hidden under Question Marks element.
      Which also should be right aligned, under Question Title, in RTL mode

      Plus, I have added a second sub issue I discovered while viewing the Question Bank page in 1024x768 mode:
      The Question Marks blocks could be moved to the left to make room for the Question's Title label.
      I have updated the proposed fix branch with another commit to reflect that fix too.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            +1 from me.

            Please cherry-pick to stable branches, then we can submit this for integration.

            Show
            timhunt Tim Hunt added a comment - +1 from me. Please cherry-pick to stable branches, then we can submit this for integration.
            Hide
            timhunt Tim Hunt added a comment -

            +1 for the revised fix too. (It is easier if you add a comment than if you edit the description.)

            Show
            timhunt Tim Hunt added a comment - +1 for the revised fix too. (It is easier if you add a comment than if you edit the description.)
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Done and ready to go!

            Show
            nadavkav Nadav Kavalerchik added a comment - Done and ready to go!
            Hide
            timhunt Tim Hunt added a comment -

            Thanks Nadav. Submitting for integration.

            Show
            timhunt Tim Hunt added a comment - Thanks Nadav. Submitting for integration.
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Rebased all branches onto latest updated branches (6-10-2012)
            Ready for integration

            Show
            nadavkav Nadav Kavalerchik added a comment - Rebased all branches onto latest updated branches (6-10-2012) Ready for integration
            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks guys, thats integrated into 22, 23 and master.

            ps: perhaps someday rtl css will have their own stylesrtl.css so it would be easier to maintain (i think).

            Show
            nebgor Aparup Banerjee added a comment - Thanks guys, thats integrated into 22, 23 and master. ps: perhaps someday rtl css will have their own stylesrtl.css so it would be easier to maintain (i think).
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Thank you Aparup.

            It is actually more easy (for me, at least) to maintain the CSS rules when the LTR rule is followed by an RTL rule. so I do not need to go and look for it (if it even exists) on a different file. (there was/is? a discussion about it here: MDL-35084)

            Show
            nadavkav Nadav Kavalerchik added a comment - Thank you Aparup. It is actually more easy (for me, at least) to maintain the CSS rules when the LTR rule is followed by an RTL rule. so I do not need to go and look for it (if it even exists) on a different file. (there was/is? a discussion about it here: MDL-35084 )
            Hide
            timhunt Tim Hunt added a comment -

            Also, all developers, whenever they add a mention of left or right in CSS, should add the corresponding body.rtl rule just after it.

            This should probably be added to the coding guidelines, peer review, and integration review checklists.

            Show
            timhunt Tim Hunt added a comment - Also, all developers, whenever they add a mention of left or right in CSS, should add the corresponding body.rtl rule just after it. This should probably be added to the coding guidelines, peer review, and integration review checklists.
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            +1 to above Tim's remark.

            Who is responsible for updated the code guidelines? (Can I add it?)

            Show
            nadavkav Nadav Kavalerchik added a comment - +1 to above Tim's remark. Who is responsible for updated the code guidelines? (Can I add it?)
            Show
            timhunt Tim Hunt added a comment - I added a comment here: http://tracker.moodle.org/browse/MDLSITE-1796?focusedCommentId=182552#comment-182552
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Beautiful!
            Potentially, It could save me a lot of work

            Show
            nadavkav Nadav Kavalerchik added a comment - Beautiful! Potentially, It could save me a lot of work
            Hide
            dmonllao David Monllaó added a comment -

            It passes, I can see the question type on the right side under the question name. Tested in 22 and master being able to reproduce the problem without the patch in both branches.

            Show
            dmonllao David Monllaó added a comment - It passes, I can see the question type on the right side under the question name. Tested in 22 and master being able to reproduce the problem without the patch in both branches.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            From somewhere within the clouds...

            Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12