Moodle
  1. Moodle
  2. MDL-35726

Save and Show Next, Next and Previous buttons in Assignment Grading copies mark/comment values to next student

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      1. create an assignment (simple direct grading or rubric)in course with multiple students
      2. click view/grade all submissions
      3. click Grade to view/grade submission for individual student
      4. add Grade or Feedback Comment
      5. click Save and Show Next or Next or Previous button

      Values from step 4 (grade, comment, etc) does NOT appear in the fields for the next student. The same thing occurs when using Next or Previous buttons. Everything works as expected.

      Show
      1. create an assignment (simple direct grading or rubric)in course with multiple students 2. click view/grade all submissions 3. click Grade to view/grade submission for individual student 4. add Grade or Feedback Comment 5. click Save and Show Next or Next or Previous button Values from step 4 (grade, comment, etc) does NOT appear in the fields for the next student. The same thing occurs when using Next or Previous buttons. Everything works as expected.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
    • Rank:
      44471

      Description

      Moodle 2.3.2 assignment grading Save and Show Next, Next, Previous buttons pulls mark and feedback comment values from current user to Next or Previous user.

      1. create an assignment (simple direct grading or rubric)in course with multiple students
      2. click view/grade all submissions
      3. click Grade to view/grade submission for individual student
      4. add Grade or Feedback Comment
      5. click Save and Show Next or Next or Previous

      Values from step 4 (grade, comment, etc) appear in the fields for the next student. Same issue occurs when using Next or Previous buttons. Assignment 2.2 not affected.

        Issue Links

          Activity

          Hide
          Mark DeLonge added a comment -

          The issue occurs with both Simple Direct Grading and Rubric Grading.

          Show
          Mark DeLonge added a comment - The issue occurs with both Simple Direct Grading and Rubric Grading.
          Hide
          Lenka Orzelová added a comment -

          I have the same problem with Moodle version 2.3.2+ (Build: 20120927). Lenka

          Show
          Lenka Orzelová added a comment - I have the same problem with Moodle version 2.3.2+ (Build: 20120927). Lenka
          Hide
          Damyon Wiese added a comment -

          Hi Raymond,

          Thinking about this change - it would cause errors in a course with 5 digit user ids when there are more than about 350 users (which is the case for some courses). This is because the userid list passed on the URL would exceed 2048 chars. This redirect will have to be done with a POST instead.

          Show
          Damyon Wiese added a comment - Hi Raymond, Thinking about this change - it would cause errors in a course with 5 digit user ids when there are more than about 350 users (which is the case for some courses). This is because the userid list passed on the URL would exceed 2048 chars. This redirect will have to be done with a POST instead.
          Hide
          Damyon Wiese added a comment -

          Fixed this by ensuring each form has a different id - so the next form will not pick up values from the previous one.

          Show
          Damyon Wiese added a comment - Fixed this by ensuring each form has a different id - so the next form will not pick up values from the previous one.
          Hide
          Clinton Branscombe added a comment -

          The problem persists in 2.3.2+ (Build: 20121005). I have had calls from teachers wondering what is going on. They found it very disconcerting.

          Show
          Clinton Branscombe added a comment - The problem persists in 2.3.2+ (Build: 20121005). I have had calls from teachers wondering what is going on. They found it very disconcerting.
          Hide
          Paul Martin added a comment -

          It states that the Fix Version(s) are the 2.3.3 and 2.4 branches only. I'm seeing the behavior in the 2.3.2+ as well, but I think that's to be expected. Can we cherry-pick the fix into our 2.3.2+ installs?

          Show
          Paul Martin added a comment - It states that the Fix Version(s) are the 2.3.3 and 2.4 branches only. I'm seeing the behavior in the 2.3.2+ as well, but I think that's to be expected. Can we cherry-pick the fix into our 2.3.2+ installs?
          Hide
          Damyon Wiese added a comment -

          You are welcome to cherry-pick it - it should not take long to get into the 2.3.2+ weeklies either.

          Show
          Damyon Wiese added a comment - You are welcome to cherry-pick it - it should not take long to get into the 2.3.2+ weeklies either.
          Hide
          Chad Bergeron added a comment -

          Manually applied the patch, but the feedback files are still appearing when moving from student to student.

          Show
          Chad Bergeron added a comment - Manually applied the patch, but the feedback files are still appearing when moving from student to student.
          Hide
          Sam Hemelryk added a comment -

          Thanks Damyon, nice solution! has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Damyon, nice solution! has been integrated now.
          Hide
          Ankit Agarwal added a comment -

          Works as expected.
          Thanks!

          Show
          Ankit Agarwal added a comment - Works as expected. Thanks!
          Hide
          Aparup Banerjee added a comment -

          Your issue has dug up some gold.
          It works great i've been told.
          Go forth, be brave, be bold.

          yay! "All your thoughts are belong to everyone."

          Thanks and ciao!

          Show
          Aparup Banerjee added a comment - Your issue has dug up some gold. It works great i've been told. Go forth, be brave, be bold. yay! "All your thoughts are belong to everyone." Thanks and ciao!
          Hide
          James Danell added a comment -

          While the grade is no longer being pulled forward to the next student, the attached Word document still is.

          Show
          James Danell added a comment - While the grade is no longer being pulled forward to the next student, the attached Word document still is.
          Hide
          Chad Bergeron added a comment -

          I am also seeing the files copied forward. Should it be reported as a new bug, as this one has been closed?

          Show
          Chad Bergeron added a comment - I am also seeing the files copied forward. Should it be reported as a new bug, as this one has been closed?
          Hide
          Mark DeLonge added a comment -

          We are seeing the same behavior with the files copied forward.

          Show
          Mark DeLonge added a comment - We are seeing the same behavior with the files copied forward.
          Hide
          Educational Technology Leaders added a comment -

          Yes, the feedback files are being copied forward too. In addition, if you replace the file from the next student, it will be replaced it on the previous one too. Should this case be reopened again or we should open a new bug? Thanks

          Show
          Educational Technology Leaders added a comment - Yes, the feedback files are being copied forward too. In addition, if you replace the file from the next student, it will be replaced it on the previous one too. Should this case be reopened again or we should open a new bug? Thanks
          Hide
          Vicki Dunnam added a comment -

          We are seeing the same with this error on files being copied to next student. Any solutions yet?

          Show
          Vicki Dunnam added a comment - We are seeing the same with this error on files being copied to next student. Any solutions yet?
          Hide
          Sam Hemelryk added a comment -

          Hi Damyon, I've added you as a watcher to be doubly sure you get this message.

          Do you have an issue for the files being copied forwards?
          If so can you please link it here, if not we need to get one created and dealt with ASAP.

          Show
          Sam Hemelryk added a comment - Hi Damyon, I've added you as a watcher to be doubly sure you get this message. Do you have an issue for the files being copied forwards? If so can you please link it here, if not we need to get one created and dealt with ASAP.
          Hide
          Damyon Wiese added a comment -

          Hi Sam,

          I created MDL-36289 - I'll put some more comments on that issue.

          • Damyon
          Show
          Damyon Wiese added a comment - Hi Sam, I created MDL-36289 - I'll put some more comments on that issue. Damyon
          Hide
          Gilles-Philippe Leblanc added a comment -

          When we fix MDL-35427, this problem appeared.

          Show
          Gilles-Philippe Leblanc added a comment - When we fix MDL-35427 , this problem appeared.

            People

            • Votes:
              14 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: