Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35728

Assignment 2.4 only - Download all submissions with team assignment generates an error when users are in the default team

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. In a course with students, but no groups
      2. Create an assignment with File submissions enabled and Students submit in teams enabled
      3. Login as one of the students and upload a file to the assignment
      4. Login as a teacher and Choose "Download all submissions" from the menu above the assignment grading table.
      5. Verify that the downloaded zip file is a valid zip file that can be unzipped.
      Show
      In a course with students, but no groups Create an assignment with File submissions enabled and Students submit in teams enabled Login as one of the students and upload a file to the assignment Login as a teacher and Choose "Download all submissions" from the menu above the assignment grading table. Verify that the downloaded zip file is a valid zip file that can be unzipped.
    • Workaround:
      Hide

      Put all students in one group.

      Show
      Put all students in one group.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      When downloading all submissions for a team assignment when users are not in any group, an error is displayed.

      Also - when blind marking is enabled the filenames are odd ( e.g. Participant-Default Team_3_xxx).

      This patch puts the group name before the username for team assignments and checks for default team to prevent the error.

        Gliffy Diagrams

          Activity

          Hide
          nebgor Aparup Banerjee added a comment -

          /me waves to Damyon

          integrated into master.

          Show
          nebgor Aparup Banerjee added a comment - /me waves to Damyon integrated into master.
          Hide
          markn Mark Nelson added a comment -

          I was able to download the zip, uncompress and view the files. Passed.

          I would just like to mention that I had two students in the course with no groups. Only one student had submitted the assignment, but in the archive I downloaded the assignment submission was shown twice, one for each student. I assume this is how 'Students submit in teams' behave but just wanted to point it out in case it wasn't.

          Show
          markn Mark Nelson added a comment - I was able to download the zip, uncompress and view the files. Passed. I would just like to mention that I had two students in the course with no groups. Only one student had submitted the assignment, but in the archive I downloaded the assignment submission was shown twice, one for each student. I assume this is how 'Students submit in teams' behave but just wanted to point it out in case it wasn't.
          Hide
          damyon Damyon Wiese added a comment -

          Thanks Mark,

          That is how I intended it to work when these 2 features are combined - but I am happy to hear suggestions for improvements.

          Show
          damyon Damyon Wiese added a comment - Thanks Mark, That is how I intended it to work when these 2 features are combined - but I am happy to hear suggestions for improvements.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          From somewhere within the clouds...

          Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/12