Moodle
  1. Moodle
  2. MDL-35730

enrol_manual user selector doesn't use current context

    Details

    • Testing Instructions:
      Hide

      1) Have a non-admin user assigned at the course or category level of the course you're testing with.
      2) Have the role they're assigned to at that course/cat level have the moodle/site:viewuseridentity capability (editingteacher for example has this at course level).
      3) Make sure site config is set to show extra fields in the user selector ($CFG->showuseridentity)
      4) When logged in as this user with this patch applied, the extra fields should be visible.

      Show
      1) Have a non-admin user assigned at the course or category level of the course you're testing with. 2) Have the role they're assigned to at that course/cat level have the moodle/site:viewuseridentity capability (editingteacher for example has this at course level). 3) Make sure site config is set to show extra fields in the user selector ($CFG->showuseridentity) 4) When logged in as this user with this patch applied, the extra fields should be visible.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      44475

      Description

      The manual enrolment user selectors base the viewing of identities off of the site context.

      This fix has the selectors informed of the current (course) context so that the useridentity check can be checked for users that only have that ability at a category (or course) level.

        Activity

        Hide
        Petr Škoda added a comment -

        Thanks for the report and patch, submitting for integration.

        Show
        Petr Škoda added a comment - Thanks for the report and patch, submitting for integration.
        Hide
        Sam Hemelryk added a comment -

        Thanks Adam, changes looked spot on and have been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Adam, changes looked spot on and have been integrated now.
        Hide
        Tim Barker added a comment -

        The test passed, great work!

        Show
        Tim Barker added a comment - The test passed, great work!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        From somewhere within the clouds...

        Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: