Moodle
  1. Moodle
  2. MDL-35740

Number of assignment submissions for all students is visible to all students through the activities block

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a course
      2. Create an assignment activity
      3. Submit the assignment using students' accounts
      4. Log on as one of the students
      5. Type in the URL http://<moodlesite>/mod/assign/index.php?id=<courseid> from the student account
      6. You will see your own assignment submission details (if it has been submitted)in week, assignments, due date, submitted time and grade columns in the activity block's table
      Show
      Create a course Create an assignment activity Submit the assignment using students' accounts Log on as one of the students Type in the URL http://<moodlesite>/mod/assign/index.php?id=<courseid> from the student account You will see your own assignment submission details (if it has been submitted)in week, assignments, due date, submitted time and grade columns in the activity block's table
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35740-master
    • Rank:
      44488

      Description

      The activities block gives a summary of the status of all a student's submissions. As a student, the new 2.3 assignment does not display any details about their own submissions, rather it shows how many submissions there has been for the whole course whereas in the 2.2 assignment type it shows Topic, Name, Assignment type, Due date, Modified and Grade.
      The steps to replicate:

      1. Create a course
      2. Create an assignment activity
      3. Submit the assignment as students
      4. Log on as one of the students
      5. Type in the URL http://<moodlesite>/mod/assign/index.php?id=<courseid> from the student account
      6. You will see how many submissions there has been for the whole course

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          This was reported by UNE testing assignment changes for 2.4

          Show
          Damyon Wiese added a comment - This was reported by UNE testing assignment changes for 2.4
          Hide
          Damyon Wiese added a comment -

          See comments in git hub - this code needs changes before re-submitting. Note: I only reviewed the master branch so all changes will need to be made to both branches.

          Show
          Damyon Wiese added a comment - See comments in git hub - this code needs changes before re-submitting. Note: I only reviewed the master branch so all changes will need to be made to both branches.
          Hide
          Raymond Antonio added a comment -

          Hi Damyon,

          Thank you very much for your feedbacks. I have updated my patch to accommodate all of them both for master and 2.3 branches. Cheers

          Show
          Raymond Antonio added a comment - Hi Damyon, Thank you very much for your feedbacks. I have updated my patch to accommodate all of them both for master and 2.3 branches. Cheers
          Hide
          Damyon Wiese added a comment -

          Hi Raymond,

          Thanks for this patch - I have converted this code to use renderers and removed some calls to deprecated functions. I'll post a new branch for 2.3 soon.

          Show
          Damyon Wiese added a comment - Hi Raymond, Thanks for this patch - I have converted this code to use renderers and removed some calls to deprecated functions. I'll post a new branch for 2.3 soon.
          Hide
          Damyon Wiese added a comment -

          This looks ready for integration now.

          Thanks Raymond.

          Show
          Damyon Wiese added a comment - This looks ready for integration now. Thanks Raymond.
          Hide
          Dan Poltawski added a comment -

          Hi,

          1. I don't understand why there is a 'nopermission' string added. I can't see where it is used and its not specific enough to warrant a new string, when we have the 'nopermissions' string in error already.
          2. I understand why you have chosen this approach and i'm not suggesting that you should change it for this issue. But if I could suggest that for the stable branches it is better for us to avoid doing refactoring the same time as bug fixes. This greatly increases the chances of regressions being introduced and its a pain for anyone who maybe modifies core a bit, so we'd rather avoid doing this on the stable branches.

          I'm reopening for the first point to be addressed, although minor.

          Show
          Dan Poltawski added a comment - Hi, I don't understand why there is a 'nopermission' string added. I can't see where it is used and its not specific enough to warrant a new string, when we have the 'nopermissions' string in error already. I understand why you have chosen this approach and i'm not suggesting that you should change it for this issue. But if I could suggest that for the stable branches it is better for us to avoid doing refactoring the same time as bug fixes. This greatly increases the chances of regressions being introduced and its a pain for anyone who maybe modifies core a bit, so we'd rather avoid doing this on the stable branches. I'm reopening for the first point to be addressed, although minor.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Damyon Wiese added a comment - - edited

          Thanks Dan,

          I have re-pushed the master branch to remove the unused language string.

          I also rebased on top of MDL-35413 and resolved conflicts with that code cleanup issue (which is why I set the blocker link). (Note the 23 branch is not based on that issue as that issue is only to be applied to 24/25).

          Re: point 2, I pushed a new branch for 23 with a minimal backport that only changes the submission column to show the status of your own submission for students.

          Show
          Damyon Wiese added a comment - - edited Thanks Dan, I have re-pushed the master branch to remove the unused language string. I also rebased on top of MDL-35413 and resolved conflicts with that code cleanup issue (which is why I set the blocker link). (Note the 23 branch is not based on that issue as that issue is only to be applied to 24/25). Re: point 2, I pushed a new branch for 23 with a minimal backport that only changes the submission column to show the status of your own submission for students.
          Hide
          Dan Poltawski added a comment -

          Hi Damyon,

          This one is conflicting a lot now with all the other changes Any chance you could rebase?

          Show
          Dan Poltawski added a comment - Hi Damyon, This one is conflicting a lot now with all the other changes Any chance you could rebase?
          Hide
          Damyon Wiese added a comment -

          Hi Dan,

          Rebased both branches - just pointing out that I based the 24/master branch on top of the branch for the unit tests/code cleanup (MDL-35413) in order to reduce conflicts (and set the blocker link).

          Thanks - Damyon

          Show
          Damyon Wiese added a comment - Hi Dan, Rebased both branches - just pointing out that I based the 24/master branch on top of the branch for the unit tests/code cleanup ( MDL-35413 ) in order to reduce conflicts (and set the blocker link). Thanks - Damyon
          Hide
          Dan Poltawski added a comment -

          Hi Damyon,

          I don't think we're gonna get the unit tests on integrated this week so this is putting bit of a blocking relationsihp with it.

          Show
          Dan Poltawski added a comment - Hi Damyon, I don't think we're gonna get the unit tests on integrated this week so this is putting bit of a blocking relationsihp with it.
          Hide
          Damyon Wiese added a comment -

          OK - Thanks Dan,

          I'll rebase both.

          Show
          Damyon Wiese added a comment - OK - Thanks Dan, I'll rebase both.
          Hide
          Damyon Wiese added a comment -

          The master branch for this issue has been rebased - this will now conflict with the unit tests and code cleanup fixes - so I'll rebase them on top of this branch once it's integrated.

          • Damyon
          Show
          Damyon Wiese added a comment - The master branch for this issue has been rebased - this will now conflict with the unit tests and code cleanup fixes - so I'll rebase them on top of this branch once it's integrated. Damyon
          Hide
          Dan Poltawski added a comment -

          Sorry, i've missed the boat with this one.

          Show
          Dan Poltawski added a comment - Sorry, i've missed the boat with this one.
          Hide
          Dan Poltawski added a comment -

          Thanks Damyon, i've integrated this now.

          Show
          Dan Poltawski added a comment - Thanks Damyon, i've integrated this now.
          Hide
          Mark Nelson added a comment -

          After asking Damyon and finding out why the table contained more information in master I am passing. Not only does this patch fix the issue with the total number of assignments being shown to the student, it also introduces more information into master. Thanks.

          Show
          Mark Nelson added a comment - After asking Damyon and finding out why the table contained more information in master I am passing. Not only does this patch fix the issue with the total number of assignments being shown to the student, it also introduces more information into master. Thanks.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Changes are now upstream, thanks for your collaboration!

          If you are going to have any celebration next days, enjoy with your gang, if not, too!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Changes are now upstream, thanks for your collaboration! If you are going to have any celebration next days, enjoy with your gang, if not, too! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: