Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35744

Wrong review options for 'Never submitted' quiz attempts

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      The unit tests cover this quite well, but ...

      1. Set up a quiz so that students are not allowed to review anything.

      2. Get a quiz attempt into the never submitted state.

      (When time expires -> Attempts must be submitted before time expires, and set a time limit. Start a quiz attempt as a student. Log out. Wait until time has expired. Log back in, and try to access the quiz attempt.)

      3. Ensure that the student cannot review the attempt.

      Show
      The unit tests cover this quite well, but ... 1. Set up a quiz so that students are not allowed to review anything. 2. Get a quiz attempt into the never submitted state. (When time expires -> Attempts must be submitted before time expires, and set a time limit. Start a quiz attempt as a student. Log out. Wait until time has expired. Log back in, and try to access the quiz attempt.) 3. Ensure that the student cannot review the attempt.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      http://moodle.org/mod/forum/post.php?reply=927252

      It looks like the first line of quiz_attempt_state is wrong.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              timhunt Tim Hunt added a comment -

              Submitting for integration.

              Show
              timhunt Tim Hunt added a comment - Submitting for integration.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated (23 & master), thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (23 & master), thanks!
              Hide
              andyjdavis Andrew Davis added a comment -

              Im not able to start a quiz attempt. When I click "attempt quiz now" I get an overlay popup. When I click "start attempt" the following JS error is generated. Looking at the changes from this issue I suspect the breaking change may have been introduced by a different MDL.

              Timestamp: 03/10/12 08:59:29
              Error: TypeError: args.name is undefined
              Source File: http://localhost/moodle/int/master/lib/javascript.php/1349224881/lib/javascript-static.js
              Line: 93

              Show
              andyjdavis Andrew Davis added a comment - Im not able to start a quiz attempt. When I click "attempt quiz now" I get an overlay popup. When I click "start attempt" the following JS error is generated. Looking at the changes from this issue I suspect the breaking change may have been introduced by a different MDL. Timestamp: 03/10/12 08:59:29 Error: TypeError: args.name is undefined Source File: http://localhost/moodle/int/master/lib/javascript.php/1349224881/lib/javascript-static.js Line: 93
              Hide
              andyjdavis Andrew Davis added a comment -

              That JS error has been fixed in MDL-35754. Just waiting for that to be integrated.

              Show
              andyjdavis Andrew Davis added a comment - That JS error has been fixed in MDL-35754 . Just waiting for that to be integrated.
              Hide
              poltawski Dan Poltawski added a comment -

              The other bugfix has been integrated.

              Show
              poltawski Dan Poltawski added a comment - The other bugfix has been integrated.
              Hide
              andyjdavis Andrew Davis added a comment -

              Now seems to be working nicely.

              Show
              andyjdavis Andrew Davis added a comment - Now seems to be working nicely.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Closing as fixed, many thanks for your awesome collaboration.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your awesome collaboration.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12