Moodle
  1. Moodle
  2. MDL-35750

countries.php is missing some new counties (such as South Sudan)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4.1, 2.5
    • Fix Version/s: 2.5
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      BEFORE UPGRADING (say, in 2.4):

      1. Create two users,
      2. Set your one USERA country to Netherlands Antilles
      3. Set USERB country to Australia

      UPGRADE to master

      1. Verify that when you login as USERA and visit profile edit page they need to choose their country and its not set to anything.
      2. Verify that when you login as USERB, they don't need to choose their country and it continues to be set as Australia
      3. Check that South Sudan appears in the countries list
      Show
      BEFORE UPGRADING (say, in 2.4): Create two users, Set your one USERA country to Netherlands Antilles Set USERB country to Australia UPGRADE to master Verify that when you login as USERA and visit profile edit page they need to choose their country and its not set to anything. Verify that when you login as USERB, they don't need to choose their country and it continues to be set as Australia Check that South Sudan appears in the countries list
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      44498

      Description

      countries.php is missing some new counties. Here are the missing codes...
      $string['BQ'] = 'Bonaire, Sint Eustatius and Saba';
      $string['CW'] = 'Curaçao';
      $string['XK'] = 'Kosovo';
      $string['SX'] = 'Sint Maarten (Dutch part)';
      $string['SS'] = 'South Sudan';

      Kosovo might be controversial since it is a temporary allocation but is used by the European Commission and others.

      See...
      http://en.wikipedia.org/wiki/ISO_3166-1_alpha-2
      http://www.iso.org/iso/home/standards/country_codes/iso-3166-1_decoding_table.htm

      I have attached a new countries.php file and a patch file.

      Alan.

      1. countries.php
        9 kB
        Alan Barrett
      2. countries.php.patch
        1 kB
        Alan Barrett

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Hi Alan,

          Thanks for your patch, sorry it wasn't looked at very quickly. I've subscribed to the mailing for updates on the ISO country codes and i've just created a script to keep our file up to date, it is here:
          https://github.com/danpoltawski/moodle-iso-country-import

          Show
          Dan Poltawski added a comment - Hi Alan, Thanks for your patch, sorry it wasn't looked at very quickly. I've subscribed to the mailing for updates on the ISO country codes and i've just created a script to keep our file up to date, it is here: https://github.com/danpoltawski/moodle-iso-country-import
          Hide
          Dan Poltawski added a comment - - edited

          I've updated the list and i'm submitting it for integration, there have been a few additions and a few name changes, nothing too contraversial I don't think.

          The big change is that Netherlands Antilles has been split up as specified in ISO 3166-1 Newsletter VI-8 (2010-12-15).

          I've made upgrade unset the country setting for users who have it set as this.

          ANYONE CHANGING THIS LIST IN THE FUTURE: The script is to update the list is here: https://github.com/danpoltawski/moodle-iso-country-import (You still need to apply some common sense to make sure it doesn't do anything stupid)

          Show
          Dan Poltawski added a comment - - edited I've updated the list and i'm submitting it for integration, there have been a few additions and a few name changes, nothing too contraversial I don't think. The big change is that Netherlands Antilles has been split up as specified in ISO 3166-1 Newsletter VI-8 (2010-12-15). I've made upgrade unset the country setting for users who have it set as this. ANYONE CHANGING THIS LIST IN THE FUTURE: The script is to update the list is here: https://github.com/danpoltawski/moodle-iso-country-import (You still need to apply some common sense to make sure it doesn't do anything stupid)
          Hide
          Dan Poltawski added a comment -

          I don't think this should be back-ported.

          Show
          Dan Poltawski added a comment - I don't think this should be back-ported.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (master only), thanks!

          PS: I'm not sure if it's correct not to backport this to stables, my feelings are that this is much like environmental or timezones information. Anyway, we have a policy now for backporting so, if anybody is interested...

          http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks! PS: I'm not sure if it's correct not to backport this to stables, my feelings are that this is much like environmental or timezones information. Anyway, we have a policy now for backporting so, if anybody is interested... http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport
          Hide
          Dan Poltawski added a comment -

          Eloy: the main reason I didn't like the idea of backporting is that it'll make users from Netherlands Antilles need to reset their country, i'm not sure its a nice thing to do in the middle of the stable branches.

          Show
          Dan Poltawski added a comment - Eloy: the main reason I didn't like the idea of backporting is that it'll make users from Netherlands Antilles need to reset their country, i'm not sure its a nice thing to do in the middle of the stable branches.
          Hide
          Dan Poltawski added a comment -

          Hmm, maybe we could do all the changes except the removal, I suppose that makes sense.

          Show
          Dan Poltawski added a comment - Hmm, maybe we could do all the changes except the removal, I suppose that makes sense.
          Hide
          Dan Poltawski added a comment -

          I've created backport request: MDL-38112

          Show
          Dan Poltawski added a comment - I've created backport request: MDL-38112
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Show
          Michael de Raadt added a comment - Test result: Success!
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: