Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35762

Grade items show up in the gradebook for students who do not meet conditions for a conditional activity.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      Apologies to whoever has to test this.

      This requires testing repeated for 22_STABLE, 23_STABLE and master.

      1. Turn on conditional activities for your site. This is done via the site setting enableavailability

      2. Create 4 assignment in a course and set the conditions for access as follows:
      A No condition so it will always be visible.
      B a condition the student won't meet, set to display greyed out.
      C a condition the student won't meet, set to hide entirely.
      D a condition the student can meet such as setting their Yahoo ID, set to hide entirely.

      3. Log in as a student and do whatever you have to do to meet condition D above.

      4. Go to the user report (click on grades in the course) and check that the four activities are displayed or hidden appropriately ie either visible and a link, visible but not a link or hidden entirely.

      5. Log in as a teacher or admin and go to the student's user report. Check that all activities are visible and are links for you.

      6. Hide one of the visible activities on the course page. Go to the categories and items screen in the gradebook and unhide that same activity. ie you've just hidden the activity but unhidden the activities' grade.

      7. Log in as the student. Check that the activity is hidden on the course page. Check that it is displayed on the user report but it should NOT be a link to the activity.
      ------------------------------------------------------------------------------
      8. Turn off the site setting enableavailability.

      9. Log in as the student and go to the user report. Check that you don't get any errors plus that now you can see all of the activities that were hidden because of conditional availability conditions. Activities that were not shown because they are hidden (eye closed icon) should remain hidden.
      ------------------------------------------------------------------------------
      10. Log in as admin. Turn on the site setting enableavailability.

      11. Create a new course. Its easier to just make this from scratch than to edit the previous course.

      12. In section 1 create 4 activities:
      A a plain visible activity with no conditional access conditions.
      B an activity with a conditional access condition the student will not meet and set to "greyed out"
      C an activity with a conditional access condition the student will not meet and set to "hidden entirely"
      D an activity with no conditions but hidden on the course page

      13. In section 2 create 2 activities. Then hide section 2. This will hide both of these activities.

      14. Go to the categories and items screen and unhide one of the activities in section 2.

      15. Log in as a student and go to the course page.

      16. Check the visibility of the activities.

      17. Go to the user report.

      18. Check the visibility of the activities.

      ------------------------------------------------------------------------------
      Repeat the testing instructions from MDL-34931.

      Show
      Apologies to whoever has to test this. This requires testing repeated for 22_STABLE, 23_STABLE and master. 1. Turn on conditional activities for your site. This is done via the site setting enableavailability 2. Create 4 assignment in a course and set the conditions for access as follows: A No condition so it will always be visible. B a condition the student won't meet, set to display greyed out. C a condition the student won't meet, set to hide entirely. D a condition the student can meet such as setting their Yahoo ID, set to hide entirely. 3. Log in as a student and do whatever you have to do to meet condition D above. 4. Go to the user report (click on grades in the course) and check that the four activities are displayed or hidden appropriately ie either visible and a link, visible but not a link or hidden entirely. 5. Log in as a teacher or admin and go to the student's user report. Check that all activities are visible and are links for you. 6. Hide one of the visible activities on the course page. Go to the categories and items screen in the gradebook and unhide that same activity. ie you've just hidden the activity but unhidden the activities' grade. 7. Log in as the student. Check that the activity is hidden on the course page. Check that it is displayed on the user report but it should NOT be a link to the activity. ------------------------------------------------------------------------------ 8. Turn off the site setting enableavailability. 9. Log in as the student and go to the user report. Check that you don't get any errors plus that now you can see all of the activities that were hidden because of conditional availability conditions. Activities that were not shown because they are hidden (eye closed icon) should remain hidden. ------------------------------------------------------------------------------ 10. Log in as admin. Turn on the site setting enableavailability. 11. Create a new course. Its easier to just make this from scratch than to edit the previous course. 12. In section 1 create 4 activities: A a plain visible activity with no conditional access conditions. B an activity with a conditional access condition the student will not meet and set to "greyed out" C an activity with a conditional access condition the student will not meet and set to "hidden entirely" D an activity with no conditions but hidden on the course page 13. In section 2 create 2 activities. Then hide section 2. This will hide both of these activities. 14. Go to the categories and items screen and unhide one of the activities in section 2. 15. Log in as a student and go to the course page. 16. Check the visibility of the activities. 17. Go to the user report. 18. Check the visibility of the activities. ------------------------------------------------------------------------------ Repeat the testing instructions from MDL-34931 .
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-35762_fix

      Description

      A teacher may create an assignment that they only wish certain users to view, for example, those who failed an assignment and need extra help. They may not want all users to see that there is an extra assignment in the course for those users, however, when viewing the gradebook the assignment is still be listed for all users. It may also confuse students who have achieved 100% for the course but can still not access it, making them question what they need to do to access it.

      IMO the item should be hidden from the gradebook if the condition is set to 'Hide activity entirely'.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12