Moodle
  1. Moodle
  2. MDL-35763

Assignment grading page shows javascript warning when changing the filter or number of rows per page.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to an assignment grading page (View/grade all submissions)
      2. Change the "Assignment per page" setting to "10"
      3. Verify you do not receive a javascript warning about unsaved data (the exact message may be browser dependant) "This page is asking you to confirm that you want to leave - data you have entered may not be saved."
      4. Change the Filter from "No filter" to "Submitted"
      5. Verify you do not receive a javascript warning about unsaved data (the exact message may be browser dependant) "This page is asking you to confirm that you want to leave - data you have entered may not be saved."
      Show
      Go to an assignment grading page (View/grade all submissions) Change the "Assignment per page" setting to "10" Verify you do not receive a javascript warning about unsaved data (the exact message may be browser dependant) "This page is asking you to confirm that you want to leave - data you have entered may not be saved." Change the Filter from "No filter" to "Submitted" Verify you do not receive a javascript warning about unsaved data (the exact message may be browser dependant) "This page is asking you to confirm that you want to leave - data you have entered may not be saved."
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
    • Rank:
      44513

      Description

      Needs ignoredirty class added to drop down lists in grading options form.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Thanks Damyon, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Damyon, this has been integrated now
          Hide
          Mark Nelson added a comment -

          Received no JS pop-up warning me that I was changing to another page. Passed.

          Show
          Mark Nelson added a comment - Received no JS pop-up warning me that I was changing to another page. Passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          From somewhere within the clouds...

          Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: