Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35767

drag and drop code seems to assume that every dragged thing has .commands

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3.2
    • 2.3.3
    • Course
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • MDL-35767-master
    • Hide
      1. Open the course and turn editing on
      2. Move one of the resources to the new place
      3. Click on "Add the activity or resource"
      4. Try moving the overlay window around the screen by dragging it.
      5. Step above should not cause JS errors.
      Show
      Open the course and turn editing on Move one of the resources to the new place Click on "Add the activity or resource" Try moving the overlay window around the screen by dragging it. Step above should not cause JS errors.

    Description

      David Monllaó discovered a problem when testing latest 3.7.2 in MDL-35616, but imo this does not seem to be specific to this new version:
      "After moving an activity or a course section (AJAX), if you open an activity chooser and you drag & drop it a JS error is thrown and there is no way to stop moving the modchooser around, I can not reproduce the problem in latest weekly 2.4." (I managed to reproduce it in latest weekly, but also 2.3.x --skodak)

      drag and drop code seems to assume that every dragged thing has .commands,
      /course/yui/dragdrop/dragdrop.js does 

      var spinner = M.util.add_spinner(Y, dragnode.one(CSS.COMMANDSPAN));

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. CONTRIB-3915 Can't add activities or resources to OU Module: subpage

          • Minor - Minor loss of function where workaround is possible
          • Open
          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34328 Browser Unresponsive when editing turned on for large courses Moodle 2.3+

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33588 dragdrop ingroup tests don't check whether a drop target is defined

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-35616 import YUI 3.7.2

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              kabalin Ruslan Kabalin
              skodak Petr Skoda
              Dan Poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Nov/12