Moodle
  1. Moodle
  2. MDL-35794

Admins should be able to control whether 'Outcomes' on the quiz form are an advanced setting

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4, 2.5
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. Ideally, ensure that you have outcomes turned off in advanced features before you upgrade. (If you did not manage that, then turn off outcomes now, and delete the row (quiz, outcomes_adv) from config_plugins.)
      2. With Outcomes turned off, visit the quiz editing form, and make sure there are no errors (e.g. undefined variable debug warnings).
      3. Turn on Outcomes, and make sure the outcomes now appear on the quiz editing form.
      4. Now change the new setting at the bottom of Plugins -> Activity modules -> Quiz, to make Outcomes advanced.
      5. Make sure outcomes are now an advanced setting on the quiz editing form, and that show/hide advanced works.
      Show
      Ideally, ensure that you have outcomes turned off in advanced features before you upgrade. (If you did not manage that, then turn off outcomes now, and delete the row (quiz, outcomes_adv) from config_plugins.) With Outcomes turned off, visit the quiz editing form, and make sure there are no errors (e.g. undefined variable debug warnings). Turn on Outcomes, and make sure the outcomes now appear on the quiz editing form. Now change the new setting at the bottom of Plugins -> Activity modules -> Quiz, to make Outcomes advanced. Make sure outcomes are now an advanced setting on the quiz editing form, and that show/hide advanced works.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      44548

      Description

      On Site administration ► Plugins ► Activity modules ► Quiz, admins can choose which settings on the quiz settings form are considere 'Advanced'. (As well as setting their default values.)

      At the moment, the is no way to mark the Outcomes settings as advanced. There should be. (It does not make sense to try to store a default for this setting.)

      This setting should only be present if 'Outcomes' are enabled on the Advanced features setting page.

      The new admin setting for this (a checkbox) should be added at the corresponding place on this page to where it appears on the quiz setting form.

      The quiz setting form should then be made to respect this.

        Activity

        Hide
        Tim Hunt added a comment -

        OK, submitting for integration.

        Show
        Tim Hunt added a comment - OK, submitting for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
        Hide
        Rajesh Taneja added a comment -

        Thanks Thanh and Tim,

        Outcomes are visible if enableoutcomes is set and shown in quiz advance settings if outcomes_adv is set.
        On other activities, edit page outcomes_adv has no affect.

        Show
        Rajesh Taneja added a comment - Thanks Thanh and Tim, Outcomes are visible if enableoutcomes is set and shown in quiz advance settings if outcomes_adv is set. On other activities, edit page outcomes_adv has no affect.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And your fantastic code has met core, hope they become good friends for a long period.

        Closing, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - And your fantastic code has met core, hope they become good friends for a long period. Closing, thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: