Loading...

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Main Branch:
w41_~~MDL-35795~~_m24_hebrewunzip
Pull Main Diff URL:
https://github.com/skodak/moodle/compare/master...w41_MDL-35795_m24_hebrewunzip
Testing Instructions:

Hide

1/ upload the attached file - for example into mod_folder
2/ switch UI to Hebrew
3/ somehow manage to edit the mod_folder files and extract the zip
4/ there should be some two files with hebrew file names

5/ zip some other files in Hebrew Windows (with Hebrew selected as default single byte legacy encoding) using built-in zipping
6/ repeat 1-4 and verify it really works

Show
1/ upload the attached file - for example into mod_folder 2/ switch UI to Hebrew 3/ somehow manage to edit the mod_folder files and extract the zip 4/ there should be some two files with hebrew file names 5/ zip some other files in Hebrew Windows (with Hebrew selected as default single byte legacy encoding) using built-in zipping 6/ repeat 1-4 and verify it really works

add extra mapping to zip_archive.php:

This should make non-utf8 Hebrew archives zipped in windows compatible with moodle if Hebrew selected as current language.

has been marked as being related by

MDL-39254 Unable to restore legacy Hebrew course_files from Moodle 1.9 backups (filename encoding issues)

Testing discovered

MDL-33753 moodle unzipping is not utf-8 compatible

Participants:: Aparup Banerjee, David Monllaó, Eloy Lafuente (stronk7), miki Alliel, Nadav Kavalerchik, Petr Skoda, Vadim Dvorovenko