Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35795

add DOS/Win hebrew unzipping fallback

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Files API
    • Labels:
    • Testing Instructions:
      Hide

      1/ upload the attached file - for example into mod_folder
      2/ switch UI to Hebrew
      3/ somehow manage to edit the mod_folder files and extract the zip
      4/ there should be some two files with hebrew file names

      5/ zip some other files in Hebrew Windows (with Hebrew selected as default single byte legacy encoding) using built-in zipping
      6/ repeat 1-4 and verify it really works

      Show
      1/ upload the attached file - for example into mod_folder 2/ switch UI to Hebrew 3/ somehow manage to edit the mod_folder files and extract the zip 4/ there should be some two files with hebrew file names 5/ zip some other files in Hebrew Windows (with Hebrew selected as default single byte legacy encoding) using built-in zipping 6/ repeat 1-4 and verify it really works
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w41_MDL-35795_m24_hebrewunzip

      Description

      add extra mapping to zip_archive.php:

      • case 'ISO-8859-8': $encoding = 'CP862'; break;

      This should make non-utf8 Hebrew archives zipped in windows compatible with moodle if Hebrew selected as current language.

        Attachments

        1. hebrew.png
          hebrew.png
          9 kB
        2. pokus.zip
          10 kB
        3. הרצאה נוספת2.zip
          10 kB

          Issue Links

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              skodak Petr Skoda
              Peer reviewer:
              Nadav Kavalerchik
              Integrator:
              Aparup Banerjee
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/12