[MDL-35802] Enrol other users UI ignores the Show user identity setting - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-35802~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-35802
Testing Instructions:

Hide

1. Select some extra fields in the Show user identity setting on User -> Permissions -> User policies
2. Go to Users -> Other uses page for any course.
3. Click the Assign roles button. Verify that those extra fields are shown for each user.
4. Search, and make sure the search text is found in the other fields, as well as in the name.
5. Also check the main Users -> Enrol users page, to ensure there are not obvious regressions caused by the refactoring.

Show
1. Select some extra fields in the Show user identity setting on User -> Permissions -> User policies 2. Go to Users -> Other uses page for any course. 3. Click the Assign roles button. Verify that those extra fields are shown for each user. 4. Search, and make sure the search text is found in the other fields, as well as in the name. 5. Also check the main Users -> Enrol users page, to ensure there are not obvious regressions caused by the refactoring.

The Enrol other users screen does not show (or search on) the extra fields chosen in the Show user identity admin setting.

In enrol/locallib.php, get_potential_users (and various other places) call get_extra_user_fields, but search_other_users does not.

Testing discovered

MDL-34657 When searching for users, list any exact matches first

Participants:: Aparup Banerjee, Eloy Lafuente (stronk7), Tim Barker, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo