Details

    • Rank:
      44579

      Description

      Issue
      Alt text - For self enrollment icon has text equivalents, but is not very significant and will be difficult to understand to some sighted users. Text for each courses currently says Self enrolment and should read something like Enroll self in <course fullname>

      Standard Level
      WCAG 2 A 1.1.1 http://www.w3.org/WAI/WCAG20/quickref/#qr-text-equiv-all

      Impact
      Moderate

      Example Link
      http://accessibility.mroomstest.net/

        Activity

        Hide
        Jason Fowler added a comment -

        A little unsure if this is the best way to do this, but can't seem to find a better way. Putting up for peer review to get some feed back.

        Show
        Jason Fowler added a comment - A little unsure if this is the best way to do this, but can't seem to find a better way. Putting up for peer review to get some feed back.
        Hide
        Adrian Greeve added a comment -

        [Y] Syntax
        [Y] Output
        [Y] Whitespace
        [-] Language
        [-] Databases
        [Y] Testing
        [-] Security
        [-] Documentation
        [Y] Git
        [Y] Sanity check

        I originally thought that it would be better to put the code in enrol_get_course_info_icons. But this requires more fooling around with the code by going through loops and finding the appropriate element.

        I think that is fine where it is. It's in the library function and seems like a good fix.

        Show
        Adrian Greeve added a comment - [Y] Syntax [Y] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check I originally thought that it would be better to put the code in enrol_get_course_info_icons. But this requires more fooling around with the code by going through loops and finding the appropriate element. I think that is fine where it is. It's in the library function and seems like a good fix.
        Hide
        Jason Fowler added a comment -

        Cherry picked back to the stable branches.

        Show
        Jason Fowler added a comment - Cherry picked back to the stable branches.
        Hide
        Sam Hemelryk added a comment -

        Hi Jason,

        Sending this back sorry just to get one thing tidied up.

        We are asking that any new format_string calls be made with at least the context argument.
        The reason for this is that filters + trust text + formatting can all be context specific.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Hi Jason, Sending this back sorry just to get one thing tidied up. We are asking that any new format_string calls be made with at least the context argument. The reason for this is that filters + trust text + formatting can all be context specific. Many thanks Sam
        Hide
        CiBoT added a comment -

        Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

        Show
        CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
        Hide
        Jason Fowler added a comment -

        Hey Sam, could you look at the way I've done it now and let me know if I have done it the way you intended?

        Show
        Jason Fowler added a comment - Hey Sam, could you look at the way I've done it now and let me know if I have done it the way you intended?
        Hide
        Sam Hemelryk added a comment -

        Hi Jason, real close. The context arg should be a context and not just its id (quickly checked in format_string).
        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Hi Jason, real close. The context arg should be a context and not just its id (quickly checked in format_string). Many thanks Sam
        Hide
        Sam Hemelryk added a comment -

        I should add a context id will work, but it will be converted into the context object anyway.
        Given you've got the whole context object already you may as well pass it.

        Feel free to put it back up when you are ready.

        Show
        Sam Hemelryk added a comment - I should add a context id will work, but it will be converted into the context object anyway. Given you've got the whole context object already you may as well pass it. Feel free to put it back up when you are ready.
        Hide
        Jason Fowler added a comment -

        All fixed now Sam

        Show
        Jason Fowler added a comment - All fixed now Sam
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Jason Fowler added a comment -

        Rebased

        Show
        Jason Fowler added a comment - Rebased
        Hide
        Sam Hemelryk added a comment -

        Thanks Jason, this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Jason, this has been integrated now.
        Hide
        David Monllaó added a comment -

        It passes, I can see an alt attribute with the expected string

        Show
        David Monllaó added a comment - It passes, I can see an alt attribute with the expected string
        Hide
        Dan Poltawski added a comment -

        Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

        Show
        Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: