Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35816 Accessibility Review issues (Deque)
  3. MDL-35833

Hide panel icon has no alt text or title

          Details

          • Testing Instructions:
            Hide
            1. Purge caches (ignore string does not exist errors until after you have done this)
            2. Dock a block
            3. hover over the docked block
            4. inspect the code for the 'x' (hide/close) button on the panel
            5. ensure it has alt text and title text attributes
            Show
            Purge caches (ignore string does not exist errors until after you have done this) Dock a block hover over the docked block inspect the code for the 'x' (hide/close) button on the panel ensure it has alt text and title text attributes
          • Affected Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
          • Fixed Branches:
            MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-MDL-35833-master
          • Pull Master Diff URL:

            Description

            Issue
            Alt text - The hide panel icon has no alt text or title. Once MDL-35828 is fixed a keyboard user will not be able to hide the panel because they will be unable to see the hide panel icon.

            Standard Level
            WCAG 2 A 1.1.1 http://www.w3.org/WAI/WCAG20/quickref/#qr-text-equiv-all

            Impact
            Serious

            Example Link
            http://demo.moodle.net/

            Test Steps

            1. Dock a block
            2. Navigate to the block via mouse
            3. Hover over the X icon next to the dock icon
            4. The user will see not text.

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  abgreeve Adrian Greeve added a comment -

                  [Y] Syntax
                  [N] Output
                  [Y] Whitespace
                  [N] Language
                  [-] Databases
                  [*] Testing
                  [-] Security
                  [-] Documentation
                  [Y] Git
                  [N] Sanity check

                  Hi Jason,

                  Just a quick note. It seems that you might have forgotten to use a language string rather than hard coding the alt and title text.

                  I think that the line should read something more like this:

                  var closeicon = Y.Node.create('<span class="hidepanelicon" tabindex="0"><img alt="'+M.str.block.hidepanel+'" title="'+M.str.block.hidedockpanel+'" /></span>');

                  • Your new strings should be put in lang/en/block.php.
                  • You will also have to alter lib/outputrequirementslib.php to define your strings. (line 410)

                  Step three of your testing instructions had me thinking that you meant the delete button. Maybe you could clarify that just a little bit more.

                  Thanks.

                  Show
                  abgreeve Adrian Greeve added a comment - [Y] Syntax [N] Output [Y] Whitespace [N] Language [-] Databases [*] Testing [-] Security [-] Documentation [Y] Git [N] Sanity check Hi Jason, Just a quick note. It seems that you might have forgotten to use a language string rather than hard coding the alt and title text. I think that the line should read something more like this: var closeicon = Y.Node.create('<span class="hidepanelicon" tabindex="0"><img alt="'+M.str.block.hidepanel+'" title="'+M.str.block.hidedockpanel+'" /></span>'); Your new strings should be put in lang/en/block.php. You will also have to alter lib/outputrequirementslib.php to define your strings. (line 410) Step three of your testing instructions had me thinking that you meant the delete button. Maybe you could clarify that just a little bit more. Thanks.
                  Hide
                  Permalink
                  phalacee Jason Fowler added a comment -

                  Thanks for catching that Adrian - didn't know we could do that for string is JS ... will also update the test instructions to make it clearer ...

                  Show
                  phalacee Jason Fowler added a comment - Thanks for catching that Adrian - didn't know we could do that for string is JS ... will also update the test instructions to make it clearer ...
                  Hide
                  Permalink
                  phalacee Jason Fowler added a comment -

                  Changes made, tested myself, pushing for integration

                  Show
                  phalacee Jason Fowler added a comment - Changes made, tested myself, pushing for integration
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Jason, this has been integrated now.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Jason, this has been integrated now.
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Tested during integration review. Passed.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Tested during integration review. Passed.
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Did you know that your awesome changes are the last ones landing to CVS?

                  After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well.

                  Closing this as fixed, many thanks!

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Did you know that your awesome changes are the last ones landing to CVS? After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well. Closing this as fixed, many thanks!

                    People

                    • Votes:
                      1 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        14/Jan/13