Details

    • Testing Instructions:
      Hide

      Testing should be completed with the JS console open in at least IE/Firefox/Chrome:

      • Ensure that you're using the Standard theme
      • Ensure that the doctonewwindow setting is off
      • Open a course
      • Turn editing on
      • At the bottom of the page, click the 'Moodle docs for this page' button
        • Confirm that the page opens in the current window
      • Return to the course
      • Open the Activity Chooser
      • Select an activity
      • Scroll to the bottom of its help
      • Click the 'More help' button
        • Confirm that the page opens as a popup
      • Turn the 'doctonewwindow' setting on
      • Refresh the course page
      • At the bottom of the page, click the 'Moodle docs for this page' button
        • Confirm that the page opens as a popup
      • Open the Activity Chooser again
      • Find and select a 'More help' button
        • Confirm that the page opens as a popup
      Show
      Testing should be completed with the JS console open in at least IE/Firefox/Chrome: Ensure that you're using the Standard theme Ensure that the doctonewwindow setting is off Open a course Turn editing on At the bottom of the page, click the 'Moodle docs for this page' button Confirm that the page opens in the current window Return to the course Open the Activity Chooser Select an activity Scroll to the bottom of its help Click the 'More help' button Confirm that the page opens as a popup Turn the 'doctonewwindow' setting on Refresh the course page At the bottom of the page, click the 'Moodle docs for this page' button Confirm that the page opens as a popup Open the Activity Chooser again Find and select a 'More help' button Confirm that the page opens as a popup
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35836-master

      Description

      The doctonewwindow setting alter Moodle help links such that they open in a new popup. It appears as though each link is made using an on click event, which we know to be pretty inefficient.

      It should be relatively easy to modify them such that event delegation is used on all such help links. The links that are opened are the same link as on the anchor.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  10 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12