Moodle
  1. Moodle
  2. MDL-35245 Missing scrollbar in Activity Chooser, when in RTL mode
  3. MDL-35837

Additional fix to supplement MDL-35245 - Missing scrollbar in Activity Chooser, in RTL mode

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs)
      2. Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting)
      3. Navigate to any course
      4. Turn "editing" mode on
      5. Click the "+ Add resource or activity" link (on the bottom of each Topic)
      6. Resize the browser and make it smaller so the dialog that pops up is not able to show all the activities and resources one page
      7. Make sure you see a scrollbar appear, next to the Activities and Resources list (the the left)
      Show
      Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs) Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting) Navigate to any course Turn "editing" mode on Click the "+ Add resource or activity" link (on the bottom of each Topic) Resize the browser and make it smaller so the dialog that pops up is not able to show all the activities and resources one page Make sure you see a scrollbar appear, next to the Activities and Resources list (the the left)
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Rank:
      44600

      Description

        Activity

        Hide
        Mary Evans added a comment -

        Nadav, If you are only fixing 2.3 then please also change the fix version when editing this.
        Thank you

        Show
        Mary Evans added a comment - Nadav, If you are only fixing 2.3 then please also change the fix version when editing this. Thank you
        Hide
        Mary Evans added a comment -

        When you are finished here please let me know and I'll set for Integ'n/Review

        Show
        Mary Evans added a comment - When you are finished here please let me know and I'll set for Integ'n/Review
        Hide
        Nadav Kavalerchik added a comment -

        Done

        Show
        Nadav Kavalerchik added a comment - Done
        Hide
        Aparup Banerjee added a comment -

        Hi guys,
        we need some basic RTL testing instructions here.

        Show
        Aparup Banerjee added a comment - Hi guys, we need some basic RTL testing instructions here.
        Hide
        Nadav Kavalerchik added a comment -

        Me bad Sorry.
        Just added some testing instructions

        Show
        Nadav Kavalerchik added a comment - Me bad Sorry. Just added some testing instructions
        Hide
        Aparup Banerjee added a comment -

        Thanks , integrated into 23 only. (MDL-35245 added it to master)

        Show
        Aparup Banerjee added a comment - Thanks , integrated into 23 only. ( MDL-35245 added it to master)
        Hide
        David Monllaó added a comment -

        It passes, I've been able to reproduce the problem without the patch and to check the patch solves the problem. Tested in 23

        Show
        David Monllaó added a comment - It passes, I've been able to reproduce the problem without the patch and to check the patch solves the problem. Tested in 23
        Hide
        Eloy Lafuente (stronk7) added a comment -

        From somewhere within the clouds...

        Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: