Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.5, 2.3.2, 2.4
-
Component/s: Enrolments
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
-
Fixed Branches:MOODLE_22_STABLE, MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:w41_
MDL-35839_m24_enroldeletecleanup -
Pull Master Diff URL:
-
Rank:44602
Description
public function delete_instance($instance) {
uses invalid component for roles and group members, please note this affects only plugins that hack enrolments in a weird way - that is have roles or groups linked to instance without actually enrolling users.
Activity
Hi Petr,
there are no phpunit tests for 22 and 23 here so we need to elaborate on testing those branches
Show
Aparup Banerjee
added a comment - Hi Petr,
there are no phpunit tests for 22 and 23 here so we need to elaborate on testing those branches
Code review should be enough in those branches, the bug was an obvious typo.
Show
Petr Škoda
added a comment - Code review should be enough in those branches, the bug was an obvious typo.
Thanks, integrated into 22, 23 and master.
Show
Aparup Banerjee
added a comment - Thanks, integrated into 22, 23 and master.
passing based on review and phpunit tests working in master.
Show
Aparup Banerjee
added a comment - passing based on review and phpunit tests working in master.
From somewhere within the clouds...
Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!
Ciao 
Show
Eloy Lafuente (stronk7)
added a comment - From somewhere within the clouds...
Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!
Ciao
I hope it is unlikely that this would create problems with existing plugins, I have discovered this when working on the new cohort to group sync plugin.