Moodle

buggy enrol_instance delete final cleanup

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2.5, 2.3.2, 2.4
  • Fix Version/s: 2.2.6, 2.3.3
  • Component/s: Enrolments
  • Labels:

Description

public function delete_instance($instance) {

uses invalid component for roles and group members, please note this affects only plugins that hack enrolments in a weird way - that is have roles or groups linked to instance without actually enrolling users.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda added a comment -

I hope it is unlikely that this would create problems with existing plugins, I have discovered this when working on the new cohort to group sync plugin.

Show
Petr Škoda added a comment - I hope it is unlikely that this would create problems with existing plugins, I have discovered this when working on the new cohort to group sync plugin.
Hide
Permalink
Aparup Banerjee added a comment -

Hi Petr,
there are no phpunit tests for 22 and 23 here so we need to elaborate on testing those branches

Show
Aparup Banerjee added a comment - Hi Petr, there are no phpunit tests for 22 and 23 here so we need to elaborate on testing those branches
Hide
Permalink
Petr Škoda added a comment -

Code review should be enough in those branches, the bug was an obvious typo.

Show
Petr Škoda added a comment - Code review should be enough in those branches, the bug was an obvious typo.
Hide
Permalink
Aparup Banerjee added a comment -

Thanks, integrated into 22, 23 and master.

Show
Aparup Banerjee added a comment - Thanks, integrated into 22, 23 and master.
Hide
Permalink
Aparup Banerjee added a comment -

passing based on review and phpunit tests working in master.

Show
Aparup Banerjee added a comment - passing based on review and phpunit tests working in master.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

From somewhere within the clouds...

Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: