Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35866

Forum RSS feed in grouping mode

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.2.4
    • Fix Version/s: None
    • Component/s: Forum, RSS
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE

      Description

      When a forum is in grouping mode, its RSS feed throws SQL error. The file mod/forum/rsslib.php is a mess, looks like being in the middle on transitioning/refactoring.

      Reading through the code, I think the grouping handling code was added later in 5/2010, but because the caching relied on the exact hardcoded SQL, whereas the new code tried to be compliant with passing in params separately. Thus, some functions set up the $params variable but never returned it to be passed into $DB->get_records_sql().

      I cleaned the codes, ran some smoke testing. Attached is the patch file (no git URL, forgive me for being afraid of endless rebasing a git branch, and also the 2.3 branch might have conflict for it has cleaned up the doc-block)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              sillyxone Huy Hoang
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: