Details

    • Testing Instructions:
      Hide
      1. Log in as a student
      2. Go to the My Moodle page
      3. Click the customize this page button
      4. Inspect the code for the "Add a block" block
      5. Ensure there is a label for the select field
      6. Ensure the label is not visible on the page
      Show
      Log in as a student Go to the My Moodle page Click the customize this page button Inspect the code for the "Add a block" block Ensure there is a label for the select field Ensure the label is not visible on the page
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-35874-master

      Description

      Issue
      Explicit labels - The select input (drop down menu) for the "Add a block" section has no label associated to it.
      Title attributes - The select input (drop down menu) for the "Add a block" section has no title attribute associated to it. Given the organization of the interface, using a title attribute with a value of "Add a block" would be helpful to non-sighted users.

      Standard Level
      WCAG 2 1.1.1 (A) http://www.w3.org/WAI/WCAG20/quickref/#qr-text-equiv-all

      Impact
      Serious

      Example Link
      http://demo.moodle.net/user/profile.php?id=0&sesskey=ZdAicfllpV&bui_moveid=293

      Test Steps

      1. Login as student
      2. Click on student's name
      3. Click the customize this page button
      4. Tab to the add a block drop down with a screen reader.

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          I can confirm that. It looks like we missed that one.

          Show
          salvetore Michael de Raadt added a comment - I can confirm that. It looks like we missed that one.
          Hide
          phalacee Jason Fowler added a comment -

          I've added the label, but used CSS to reposition it off the screen so the page layout isn't affected. This should allow screen readers to identify the field (via the for attribute) while preventing changes to the page for sighted users.

          Show
          phalacee Jason Fowler added a comment - I've added the label, but used CSS to reposition it off the screen so the page layout isn't affected. This should allow screen readers to identify the field (via the for attribute) while preventing changes to the page for sighted users.
          Hide
          phalacee Jason Fowler added a comment -

          need to use accesshide in the class attribute - it's a nice way to do this.

          Show
          phalacee Jason Fowler added a comment - need to use accesshide in the class attribute - it's a nice way to do this.
          Hide
          phalacee Jason Fowler added a comment -

          Implemented .accesshide now - works as it did before, only in less code, and it's nicer. So glad Fred mentioned this before I put it up for integration.

          Show
          phalacee Jason Fowler added a comment - Implemented .accesshide now - works as it did before, only in less code, and it's nicer. So glad Fred mentioned this before I put it up for integration.
          Hide
          fred Frédéric Massart added a comment -

          Looks good to me Jason. Pushing for integration. Cheers!

          Show
          fred Frédéric Massart added a comment - Looks good to me Jason. Pushing for integration. Cheers!
          Hide
          poltawski Dan Poltawski added a comment -

          Integrated to master, 24, 23 and 22 thanks Jason.

          Show
          poltawski Dan Poltawski added a comment - Integrated to master, 24, 23 and 22 thanks Jason.
          Hide
          andyjdavis Andrew Davis added a comment -

          Works as described. Passed.

          Show
          andyjdavis Andrew Davis added a comment - Works as described. Passed.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Changes are now upstream, thanks for your collaboration!

          If you are going to have any celebration next days, enjoy with your gang, if not, too!

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Changes are now upstream, thanks for your collaboration! If you are going to have any celebration next days, enjoy with your gang, if not, too! Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jan/13