Details

      Description

      Issue
      Page headings - There are no page headings for main content provided on the edit user's profile page.

      Standard Level
      WCAG 2 2.4.6 (AA) http://www.w3.org/WAI/WCAG20/quickref/#qr-navigation-mechanisms-descriptive

      Impact
      Serious

      Example Link
      http://demo.moodle.net/user/edit.php?id=5&course=1

      Test Steps

      1. Login as a student
      2. Click on the student's name
      3. Click the edit profile link in the settings block.

        Gliffy Diagrams

          Activity

          Hide
          Ankit Agarwal added a comment -

          Thanks for the report Jason.

          sending this fore review.
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks for the report Jason. sending this fore review. Thanks
          Hide
          Rossiani Wijaya added a comment -

          Hi Ankit,

          The patch is great. It will make the page looks consistent with the edit advance page.

          Check the following:
          [y] Syntax
          [y] Output
          [y] Whitespace
          [-] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Show
          Rossiani Wijaya added a comment - Hi Ankit, The patch is great. It will make the page looks consistent with the edit advance page. Check the following: [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Rosie,
          Sending for integration.,
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks for the review Rosie, Sending for integration., Thanks
          Hide
          Aparup Banerjee added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Thanks Ankit,

          I've integrated this now

          Show
          Dan Poltawski added a comment - Thanks Ankit, I've integrated this now
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Tested under 2.2, 2.3 and master as student and admin. I was also able to see the change when editing others' profiles while logged in as admin.

          Show
          Michael de Raadt added a comment - Test result: Success! Tested under 2.2, 2.3 and master as student and admin. I was also able to see the change when editing others' profiles while logged in as admin.
          Hide
          Dan Poltawski added a comment -

          Hurray!

          You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

          Show
          Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: