Details

    • Testing Instructions:
      Hide

      Test 1

      1. Login as user.
      2. Make sure title attribute is set for "user" link on top and bottom of page.
      3. With NVDA active, and using tab select user name on top and bottom and make sure you can listen "view profile"

      Test 2:

      1. Login as different user
        1. Go to "Browser list of users" as admin (Site administration ► Users ► Accounts ► Browse list of users)
        2. Click on any user to view profile ( Users ► Adrian Adams ► View profile)
        3. Click on "Login as" (Administration -> Profile settings for student1 -> Login as) to log in as that user.
      2. Make sure title attribute is set for "Admin user" link and "user" link (On top right and bottom of page)
      3. With NVDA, make sure tabbing on login as and user name link define context of link.
      Show
      Test 1 Login as user. Make sure title attribute is set for "user" link on top and bottom of page. With NVDA active, and using tab select user name on top and bottom and make sure you can listen "view profile" Test 2: Login as different user Go to "Browser list of users" as admin (Site administration ► Users ► Accounts ► Browse list of users) Click on any user to view profile ( Users ► Adrian Adams ► View profile) Click on "Login as" (Administration -> Profile settings for student1 -> Login as) to log in as that user. Make sure title attribute is set for "Admin user" link and "user" link (On top right and bottom of page) With NVDA, make sure tabbing on login as and user name link define context of link.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull 2.4 Branch:
      wip-mdl-35883-m24
    • Pull Master Branch:
      wip-mdl-35883
    • Rank:
      44648

      Description

      Issue
      Link Purpose - One link has two different link texts : Sam Student(header and footer links) and View Profile (under Navigation block and My profile group).

      Standard Level
      WCAG 2 2.4.4 (A) http://www.w3.org/WAI/WCAG20/quickref/#qr-navigation-mechanisms-refs

      Impact
      Moderate

      Example Link
      http://demo.moodle.net/course/view.php?id=625

      Test Steps

      1. Login as a student
      2. navigate to DEMO SCIENCE COURSE
      3. Expand the Navigation block > My Profile link

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment - - edited

          Perhaps we can have "Sam Student" as text and next to it "View profile" as a link. That would give us consistency between these links and still inform the user of what account they are logged in as.

          Show
          Michael de Raadt added a comment - - edited Perhaps we can have "Sam Student" as text and next to it "View profile" as a link. That would give us consistency between these links and still inform the user of what account they are logged in as.
          Hide
          Rajesh Taneja added a comment -

          Thanks for reporting this Jason,

          I am not sure if anything is wrong in having two links (with different names), pointing to same url.

          As per standard: The purpose of each link can be determined from the link text alone or from the link text together with its programmatically determined link context.

          which seems to be fine here. Also, looking at G19, G53, it seems current implementation is fine, as enclosing text or text on link is sufficiently explaining the link.

          Please suggest if we are missing something here.

          Show
          Rajesh Taneja added a comment - Thanks for reporting this Jason, I am not sure if anything is wrong in having two links (with different names), pointing to same url. As per standard: The purpose of each link can be determined from the link text alone or from the link text together with its programmatically determined link context. which seems to be fine here. Also, looking at G19 , G53 , it seems current implementation is fine, as enclosing text or text on link is sufficiently explaining the link. Please suggest if we are missing something here.
          Hide
          Michael de Raadt added a comment -

          It is true that these links appear in slightly different contexts. The links in the header and footer indicate the name of the user logged in where the link in the navigation appears below the text "My profile".

          We could make the change I suggested above, but do we really need to.

          What do you think, Jason?

          Show
          Michael de Raadt added a comment - It is true that these links appear in slightly different contexts. The links in the header and footer indicate the name of the user logged in where the link in the navigation appears below the text "My profile". We could make the change I suggested above, but do we really need to. What do you think, Jason?
          Hide
          Jason Hardin added a comment - - edited

          I believe the issue is that the first link actually does not convey context. The reason for this is that Sam Student is ambiguous especially when seen in light of the same url with a different name. View profile sets the context of where I am going when i click the link Sam Student does not unless I look at the exact url to determine where I am going. Even then I only know I am going to user/view.php I can assume that is viewing the user but I can't be certain.

          I think Michael's suggestion would be a fine solution. We have implemented different link names based on what the user will be doing and not linking the user's name to anything other than an expandable menu with the correct aria tags.

          I would point to the attached links Techniques item 8. THis describes the programmatically determine link context using the previous information around the link, which Sam student does not provide in my opinion. Another option would be just to add a title that says view profile as per item 7 in the link.

          Show
          Jason Hardin added a comment - - edited I believe the issue is that the first link actually does not convey context. The reason for this is that Sam Student is ambiguous especially when seen in light of the same url with a different name. View profile sets the context of where I am going when i click the link Sam Student does not unless I look at the exact url to determine where I am going. Even then I only know I am going to user/view.php I can assume that is viewing the user but I can't be certain. I think Michael's suggestion would be a fine solution. We have implemented different link names based on what the user will be doing and not linking the user's name to anything other than an expandable menu with the correct aria tags. I would point to the attached links Techniques item 8. THis describes the programmatically determine link context using the previous information around the link, which Sam student does not provide in my opinion. Another option would be just to add a title that says view profile as per item 7 in the link.
          Hide
          Rajesh Taneja added a comment -

          Thanks for the feedback Jason,

          I have added title for user profile link.

          Show
          Rajesh Taneja added a comment - Thanks for the feedback Jason, I have added title for user profile link.
          Hide
          Jason Fowler added a comment -

          [Y] Syntax
          [Y] Output
          [Y] Whitespace
          [Y] Language
          [-] Databases
          [Y] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Show
          Jason Fowler added a comment - [Y] Syntax [Y] Output [Y] Whitespace [Y] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Hi Raj,

          Please could you clarify the testing instructions on this issue - they do not make clear that we are talking about the loginas feature, and not just the normal login page.

          Show
          Dan Poltawski added a comment - Hi Raj, Please could you clarify the testing instructions on this issue - they do not make clear that we are talking about the loginas feature, and not just the normal login page.
          Hide
          Rajesh Taneja added a comment -

          Thanks Dan,

          done.

          Show
          Rajesh Taneja added a comment - Thanks Dan, done.
          Hide
          Dan Poltawski added a comment -

          Integrated to master, 24 and 23 - thanks Raj.

          (Btw, to give my two cents - I would probably have converted those urls to moodle_urls, rather than continue to have the ugly &amp and escaped quote marks etc, but there you go )

          Show
          Dan Poltawski added a comment - Integrated to master, 24 and 23 - thanks Raj. (Btw, to give my two cents - I would probably have converted those urls to moodle_urls, rather than continue to have the ugly &amp and escaped quote marks etc, but there you go )
          Hide
          Damyon Wiese added a comment -

          I'll test this now.

          Show
          Damyon Wiese added a comment - I'll test this now.
          Hide
          Damyon Wiese added a comment -

          This solution does not do what is intended. When tabbing to the user link, NVDA reads "Admin User link" and completely ignores the title attribute.

          Sorry (I followed the testing instructions)!

          Show
          Damyon Wiese added a comment - This solution does not do what is intended. When tabbing to the user link, NVDA reads "Admin User link" and completely ignores the title attribute. Sorry (I followed the testing instructions)!
          Hide
          Damyon Wiese added a comment -

          So - interesting note for accessibility testing - NVDA only reads the title attribute for links in Firefox - not chrome or IE.

          Show
          Damyon Wiese added a comment - So - interesting note for accessibility testing - NVDA only reads the title attribute for links in Firefox - not chrome or IE.
          Hide
          Damyon Wiese added a comment -

          From testing various screen readers in different browsers it seems that reading the title attribute of a link that has content is rarely supported - in fact NVDA with firefox was the only supported combination.

          It would be good to know what happens with chrome - but we also tested the screen reader on iOS and that did not read the title attribute.

          Reading through the linked document in this issue it says:

          Because of the extensive user agent limitations in supporting access to the title attribute, authors should use caution in applying this technique. For this reason, it is preferred that the author use technique C7: Using CSS to hide a portion of the link text (CSS) or H30: Providing link text that describes the purpose of a link for anchor elements.

          We can modify the testing instructions to pass it because it is consistent to how we have been addressing this in other issues - but IMO it is flawed and does not help 99% of people.

          Will raise a new issue for this as it applies more broadly than just this one link.

          This issue can pass as it works as expected (but only in NVDA/firefox).

          Show
          Damyon Wiese added a comment - From testing various screen readers in different browsers it seems that reading the title attribute of a link that has content is rarely supported - in fact NVDA with firefox was the only supported combination. It would be good to know what happens with chrome - but we also tested the screen reader on iOS and that did not read the title attribute. Reading through the linked document in this issue it says: Because of the extensive user agent limitations in supporting access to the title attribute, authors should use caution in applying this technique. For this reason, it is preferred that the author use technique C7: Using CSS to hide a portion of the link text (CSS) or H30: Providing link text that describes the purpose of a link for anchor elements. We can modify the testing instructions to pass it because it is consistent to how we have been addressing this in other issues - but IMO it is flawed and does not help 99% of people. Will raise a new issue for this as it applies more broadly than just this one link. This issue can pass as it works as expected (but only in NVDA/firefox).
          Hide
          Damyon Wiese added a comment -

          Passing but will raise new issue.

          Show
          Damyon Wiese added a comment - Passing but will raise new issue.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your awesome contributions are now part of Moodle, your fav LMS out there.

          Closing this as fixed.

          Many thanks for all the hard work, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Your awesome contributions are now part of Moodle, your fav LMS out there. Closing this as fixed. Many thanks for all the hard work, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: