Perhaps for complete correctness, the title on the link and the alt on the image should not be the same, but the most appropriate value.

See http://docs.moodle.org/dev/Accessibility#Moodle-related_accessibility_coding_guidelines

requesting peer review before I cherry-pick to stable branches

Patch looks good Jason,
Personally I would have left component = null, as it should take default value from the api (Original case).

Feel free to push it for integration.
[y] Syntax
[y] Output
[y] Whitespace
[-] Language
[-] Databases
[y] Testing
[-] Security
[-] Documentation
[y] Git
[y] Sanity check

Looking at this again, just wondering if we really need title for this?
Don't you think + is only for display purpose, why would a user need title popup with same string as it appears next to it.

Thanks for pointing that out Raj, will remove the title as well.

Changes made, going for integration now

Related dicussion to this: https://moodle.org/mod/forum/discuss.php?d=197963

I have some reservations about this, mostly because I am not an expert in this area. Is it really better for us to use these empty strings?

If so, should the pix_icon renderer really be '@param string $alt mandatory alt attribute'? I'd like some more opinions on this, so asking around.

I'm not sure about the pix_icon alt attribute being mandatory, but the empty strings are correct in this case.

http://www.un.org/webaccessibility/1_visual/11_alternativetext.shtml explains:

If an image does not convey any information and only serves a decorative purpose, add an empty "alt" attribute. Decorative elements can be defined in a CSS style sheet.

Hi Jason,

Thanks, that link is useful. I discussed with the integrators and confirmed that your approach is the correct one.

However, i'm afraid there is an unrelated line change on the 23 branch, so reopening this for that to be fixed up:
https://github.com/phalacee/moodle/compare/MOODLE_23_STABLE...wip-MDL-35884-s23

Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

Made the fix as requested Dan - two commits, one to fix the issue, the second to fix the whitespace/character return problem.

Pushing for integration again

Thanks Jason, i've integrated this now to master, 24 and 23.

Tested on the 2.3 and master integration branches.
The alt and title strings are now empty.
No problems found.
Test passed.

Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

Closing, ciao