Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35816 Accessibility Review issues (Deque)
  3. MDL-35885

Wiki search field set missing legend

          Details

          • Testing Instructions:
            Hide
            1. Login as teacher
            2. Navigate to a course
            3. Create a wiki
            4. Create a first page
            5. View the source for the search wikis form in the upper right and you will see a legend for the field set explaining what the field set is for
            6. Ensure the legend does not appear on screen
            Show
            Login as teacher Navigate to a course Create a wiki Create a first page View the source for the search wikis form in the upper right and you will see a legend for the field set explaining what the field set is for Ensure the legend does not appear on screen
          • Affected Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
          • Fixed Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-MDL-35885-master
          • Pull Master Diff URL:

            Description

            Issue
            Form Label - The fieldset defined for wiki search is missing legend

            Standard Level
            WCAG 2 1.1.1 (A) http://www.w3.org/WAI/WCAG20/quickref/#qr-text-equiv-all

            Impact
            Critical

            Example Link
            http://demo.moodle.net/mod/wiki/edit.php?pageid=56

            Test Steps

            1. Login as teacher
            2. Navigate to the demo science course
            3. Create a wiki
            4. Create a first page
            5. View the source for the search wikis form in the upper right and you will see no legend for the field set explaining what the field set is for.

              Gliffy Diagrams

                Attachments

                  Issue Links

                  is a clone of

                  Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-35889 Search forums block search fieldset missing legend

                  • Major - Major loss of function, incorrect output
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment -

                    sorry for the noise, edited the wrong issue

                    Show
                    ankit_frenz Ankit Agarwal added a comment - sorry for the noise, edited the wrong issue
                    Hide
                    Permalink
                    rajeshtaneja Rajesh Taneja added a comment -

                    Thanks Jason,

                    Patch looks good, just wondering if label text should be different then legend text. As this is accessibility issue how both will be read (one after other.)

                    FYI: Please fill test instruction before pushing it for integration.

                    [y] Syntax
                    [y] Output
                    [N] Whitespace (There is mismatch of space before and after get_string concatenation)
                    [-] Language
                    [-] Databases
                    [y] Testing
                    [-] Security
                    [-] Documentation
                    [y] Git
                    [y] Sanity check

                    Show
                    rajeshtaneja Rajesh Taneja added a comment - Thanks Jason, Patch looks good, just wondering if label text should be different then legend text. As this is accessibility issue how both will be read (one after other.) FYI: Please fill test instruction before pushing it for integration. [y] Syntax [y] Output [N] Whitespace (There is mismatch of space before and after get_string concatenation) [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
                    Hide
                    Permalink
                    phalacee Jason Fowler added a comment -

                    Problems all solved, testing instructions, then pushing for integration

                    Show
                    phalacee Jason Fowler added a comment - Problems all solved, testing instructions, then pushing for integration
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                    TIA and ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks Jason, this has been integrated now.

                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks Jason, this has been integrated now.
                    Hide
                    Permalink
                    dmonllao David Monllaó added a comment -

                    It passes, works as described in the testing instructions

                    Show
                    dmonllao David Monllaó added a comment - It passes, works as described in the testing instructions
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

                    Show
                    poltawski Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        8 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          11/Mar/13