Moodle

Wiki search field set missing legend

Details

Description

Issue
Form Label - The fieldset defined for wiki search is missing legend

Standard Level
WCAG 2 1.1.1 (A) http://www.w3.org/WAI/WCAG20/quickref/#qr-text-equiv-all

Impact
Critical

Example Link
http://demo.moodle.net/mod/wiki/edit.php?pageid=56

Test Steps

  1. Login as teacher
  2. Navigate to the demo science course
  3. Create a wiki
  4. Create a first page
  5. View the source for the search wikis form in the upper right and you will see no legend for the field set explaining what the field set is for.

Issue Links

is a clone of

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-35889 Search forums block search fieldset missing legend

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ankit Agarwal added a comment -

sorry for the noise, edited the wrong issue

Show
Ankit Agarwal added a comment - sorry for the noise, edited the wrong issue
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Jason,

Patch looks good, just wondering if label text should be different then legend text. As this is accessibility issue how both will be read (one after other.)

FYI: Please fill test instruction before pushing it for integration.

[y] Syntax
[y] Output
[N] Whitespace (There is mismatch of space before and after get_string concatenation)
[-] Language
[-] Databases
[y] Testing
[-] Security
[-] Documentation
[y] Git
[y] Sanity check

Show
Rajesh Taneja added a comment - Thanks Jason, Patch looks good, just wondering if label text should be different then legend text. As this is accessibility issue how both will be read (one after other.) FYI: Please fill test instruction before pushing it for integration. [y] Syntax [y] Output [N] Whitespace (There is mismatch of space before and after get_string concatenation) [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
Hide
Permalink
Jason Fowler added a comment -

Problems all solved, testing instructions, then pushing for integration

Show
Jason Fowler added a comment - Problems all solved, testing instructions, then pushing for integration
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Jason, this has been integrated now.

Show
Sam Hemelryk added a comment - Thanks Jason, this has been integrated now.
Hide
Permalink
David Monllaó added a comment -

It passes, works as described in the testing instructions

Show
David Monllaó added a comment - It passes, works as described in the testing instructions
Hide
Permalink
Dan Poltawski added a comment -

Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

Show
Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

People

Vote (0)
Watch (8)

Dates

  • Created:
    Updated:
    Resolved: