Details

    • Rank:
      44654

      Description

      Issue
      Form Label - The fieldset defined for forum search in the forum search block is missing a legend

      Standard Level
      WCAG 2 1.1.1 (A) http://www.w3.org/WAI/WCAG20/quickref/#qr-text-equiv-all

      Impact
      Critical

      Example Link
      http://demo.moodle.net/course/view.php?id=625&notifyeditingon=1

      Test Steps

      1. Login as teacher
      2. Navigate to the demo science course
      3. View the source for the search forums block form in the upper right and you will see no legend for the field set explaining what the field set is for.

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          Sending for review

          Show
          Ankit Agarwal added a comment - Sending for review
          Hide
          Rossiani Wijaya added a comment -

          Hi Ankit,

          This looks great. I reviewed it in 2.2, 2.3 and 2.4.

          Reviewed list:
          [y] Syntax
          [y] Output
          [y] Whitespace
          [y] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Show
          Rossiani Wijaya added a comment - Hi Ankit, This looks great. I reviewed it in 2.2, 2.3 and 2.4. Reviewed list: [y] Syntax [y] Output [y] Whitespace [y] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Rosie.
          Sending for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks for the review Rosie. Sending for integration. Thanks
          Hide
          Aparup Banerjee added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Ankit, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Ankit, this has been integrated now
          Hide
          Mark Nelson added a comment -

          Legend tag is present with the class 'accesshide'. Passing.

          Show
          Mark Nelson added a comment - Legend tag is present with the class 'accesshide'. Passing.
          Hide
          Dan Poltawski added a comment -

          Hurray!

          You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

          Show
          Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: