Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35892

Repository function prepare_listing should work recursively

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.3.2
          • Fix Version/s: 2.3.3
          • Component/s: Repositories
          • Labels:
          • Testing Instructions:
            Hide

            Pre-requisites

            • Box.net and Dropbox repository including sub folders, images and files

            Test

            1. Go to your private files
            2. Browse box.net and Dropbox and make sure you can freely browse them
            3. Go to any description and pick an image using TinyMCE editor
            4. Make sure Dropbox and Box.net work and only display images
            Show
            Pre-requisites Box.net and Dropbox repository including sub folders, images and files Test Go to your private files Browse box.net and Dropbox and make sure you can freely browse them Go to any description and pick an image using TinyMCE editor Make sure Dropbox and Box.net work and only display images
          • Affected Branches:
            MOODLE_23_STABLE
          • Fixed Branches:
            MOODLE_23_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-35892-master
          • Pull Master Diff URL:

            Description

            The function prepare_listing should work on the children element to set the icons and reset the keys.

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  fred Frédéric Massart added a comment -

                  Here is a patch to recursively prepare the listing returned by a repository. I have extracted the functions that clean up the $list and $path to make them recursive or more readable.

                  Show
                  fred Frédéric Massart added a comment - Here is a patch to recursively prepare the listing returned by a repository. I have extracted the functions that clean up the $list and $path to make them recursive or more readable.
                  Hide
                  Permalink
                  marina Marina Glancy added a comment -

                  Fred, looks good to me

                  Show
                  marina Marina Glancy added a comment - Fred, looks good to me
                  Hide
                  Permalink
                  fred Frédéric Massart added a comment -

                  Cheers! Pushing for integration.

                  Show
                  fred Frédéric Massart added a comment - Cheers! Pushing for integration.
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Fred, has been integrated now

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Fred, has been integrated now
                  Hide
                  Permalink
                  markn Mark Nelson added a comment -

                  Test passed. Had a PDF document I was able to access when using private files, but not in the TinyMCE editor when adding an image.

                  Show
                  markn Mark Nelson added a comment - Test passed. Had a PDF document I was able to access when using private files, but not in the TinyMCE editor when adding an image.
                  Hide
                  Permalink
                  nebgor Aparup Banerjee added a comment -

                  Your issue has dug up some gold.
                  It works great i've been told.
                  Go forth, be brave, be bold.

                  yay! "All your thoughts are belong to everyone."

                  Thanks and ciao!

                  Show
                  nebgor Aparup Banerjee added a comment - Your issue has dug up some gold. It works great i've been told. Go forth, be brave, be bold. yay! "All your thoughts are belong to everyone." Thanks and ciao!

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        12/Nov/12