Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35910

Download Assignment(2.2) files as zip

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3.2
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Assignment (2.2)
    • Labels:
    • Testing Instructions:
      Hide

      Test 1
      – As a teacher create "advanced uploading of files" activity and set "Enabled send for marking" to No
      – As student upload file to this activity.
      – As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id=

      {activity_id}&download=zip)
      – Make sure the file gets included in zip

      Test 2
      – As a teacher create "advanced uploading of files" activity
      – As student1 upload file to assignment but don't send it for marking.
      – As student2 upload file to assignment and send it for marking.
      – As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id={activity_id}

      &download=zip)
      – Make sure files uploaded by student 2 are only included in zip
      – As student 1 send activity for marking
      – As teacher view submission again and click "Download all assignments as a zip" (mod/assignment/submissions.php?id=

      {activity_id}

      &download=zip)
      – Make sure files from student 1 and student 2 are included in zip.

      Show
      Test 1 – As a teacher create "advanced uploading of files" activity and set "Enabled send for marking" to No – As student upload file to this activity. – As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id= {activity_id}&download=zip) – Make sure the file gets included in zip Test 2 – As a teacher create "advanced uploading of files" activity – As student1 upload file to assignment but don't send it for marking. – As student2 upload file to assignment and send it for marking. – As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id={activity_id} &download=zip) – Make sure files uploaded by student 2 are only included in zip – As student 1 send activity for marking – As teacher view submission again and click "Download all assignments as a zip" (mod/assignment/submissions.php?id= {activity_id} &download=zip) – Make sure files from student 1 and student 2 are included in zip.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-35910

      Description

      The problem is with Assignment(2.2)- Advanced uploading of files.

      If "Enabled send for marking" button is No, then it is not possible to download submitted assignments as zip.
      All submitted assignments are missing the submitted flag from assignment_submissions table data2 field and therefore they are excluded from the zip generator.

      I think it should be possible to download the assignment files as zip even when the "Enabled send for marking" button is set No.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for reporting that. I was able to replicate the problem. It does only happen when "Send for marking" is set to no.

              Show
              salvetore Michael de Raadt added a comment - Thanks for reporting that. I was able to replicate the problem. It does only happen when "Send for marking" is set to no.
              Hide
              jlyle Jeff Lyle added a comment -

              We have this issue also - 2.2.5+ (Build: 20120927)

              Show
              jlyle Jeff Lyle added a comment - We have this issue also - 2.2.5+ (Build: 20120927)
              Hide
              jlyle Jeff Lyle added a comment -

              I can confirm that setting "Enabled send for marking" yes, then is is possible to only download those zips "sent for marking". If no files are sent for marking clicking the download all as zip states no assignments to download and prints a click here for more information on this error message.

              Show
              jlyle Jeff Lyle added a comment - I can confirm that setting "Enabled send for marking" yes, then is is possible to only download those zips "sent for marking". If no files are sent for marking clicking the download all as zip states no assignments to download and prints a click here for more information on this error message.
              Hide
              t6nis20 Tõnis Tartes added a comment -

              Made this little patch.

              When "Send for marking" button is set No, it allows to download files as zip, even drafts.

              I left the check still intact when "Send for marking" button is set Yes, then it allows to download only those assignments which are submitted finally. Maybe i should'nt done that?

              Anyway someone should review this..

              Show
              t6nis20 Tõnis Tartes added a comment - Made this little patch. When "Send for marking" button is set No, it allows to download files as zip, even drafts. I left the check still intact when "Send for marking" button is set Yes, then it allows to download only those assignments which are submitted finally. Maybe i should'nt done that? Anyway someone should review this..
              Hide
              anisj anis jradah added a comment -

              thank you for your support.

              Another test can up.

              if you select "Preventing late submissions" (changing the choice to “Yes”), it will allowed you to do the download.

              Best regards,
              anis

              Show
              anisj anis jradah added a comment - thank you for your support. Another test can up. if you select "Preventing late submissions" (changing the choice to “Yes”), it will allowed you to do the download. Best regards, anis
              Hide
              anisj anis jradah added a comment -

              Dear All,

              Please ignore my last message, I retest it and it did not work as I mentioned...

              Kindly note that I tried the patch and it did not work, it gave a white page.
              Did anyone tried it too?

              We are using: 2.2.5 (Build: 20120910)

              Thank you
              Anis

              Show
              anisj anis jradah added a comment - Dear All, Please ignore my last message, I retest it and it did not work as I mentioned... Kindly note that I tried the patch and it did not work, it gave a white page. Did anyone tried it too? We are using: 2.2.5 (Build: 20120910) Thank you Anis
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Thanks for the patch, Tõnis.

              I have just added one more condition to the existing condition. Pushing it for peer-review.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Thanks for the patch, Tõnis. I have just added one more condition to the existing condition. Pushing it for peer-review.
              Hide
              poltawski Dan Poltawski added a comment -

              Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..

              Show
              poltawski Dan Poltawski added a comment - Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..
              Hide
              chrisf Chris Fryer added a comment - - edited

              Note that this issue affects the 2.2 branch as well. Please update the "Affected versions" and "Affected branches".

              Show
              chrisf Chris Fryer added a comment - - edited Note that this issue affects the 2.2 branch as well. Please update the "Affected versions" and "Affected branches".
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated to 22, 23 and master.

              Thanks Raj.

              Show
              poltawski Dan Poltawski added a comment - Integrated to 22, 23 and master. Thanks Raj.
              Hide
              poltawski Dan Poltawski added a comment -

              Doh. This issue is missing testing instructions, please can you add them Raj?

              Show
              poltawski Dan Poltawski added a comment - Doh. This issue is missing testing instructions, please can you add them Raj?
              Hide
              markdw Mark Ward added a comment -

              This issue has been reported by a member of our staff. The supplied patch works well, many thanks Tõnis.

              Show
              markdw Mark Ward added a comment - This issue has been reported by a member of our staff. The supplied patch works well, many thanks Tõnis.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Sorry Dan,
              Added test instructions.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Sorry Dan, Added test instructions.
              Hide
              salvetore Michael de Raadt added a comment -

              Test result: Success!

              Tested in 2.2, 2.3 and master.

              Show
              salvetore Michael de Raadt added a comment - Test result: Success! Tested in 2.2, 2.3 and master.
              Hide
              poltawski Dan Poltawski added a comment -

              Hurray!

              You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

              Show
              poltawski Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

                People

                • Votes:
                  15 Vote for this issue
                  Watchers:
                  11 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12