[MDL-35910] Download Assignment(2.2) files as zip - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 2.2.5, 2.3.2
Fix Version/s: 2.2.6, 2.3.3
Component/s: Assignment (2.2)
Labels:
- triaged

Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/rajeshtaneja/moodle
Pull Master Branch:
wip-mdl-35910
Pull Master Diff URL:
https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-35910
Testing Instructions:

Hide

Test 1
– As a teacher create "advanced uploading of files" activity and set "Enabled send for marking" to No
– As student upload file to this activity.
– As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id=
{activity_id}&download=zip)
– Make sure the file gets included in zip

Test 2
– As a teacher create "advanced uploading of files" activity
– As student1 upload file to assignment but don't send it for marking.
– As student2 upload file to assignment and send it for marking.
– As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id={activity_id}
&download=zip)
– Make sure files uploaded by student 2 are only included in zip
– As student 1 send activity for marking
– As teacher view submission again and click "Download all assignments as a zip" (mod/assignment/submissions.php?id=
{activity_id}
&download=zip)
– Make sure files from student 1 and student 2 are included in zip.

Show
Test 1 – As a teacher create "advanced uploading of files" activity and set "Enabled send for marking" to No – As student upload file to this activity. – As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id= {activity_id}&download=zip) – Make sure the file gets included in zip Test 2 – As a teacher create "advanced uploading of files" activity – As student1 upload file to assignment but don't send it for marking. – As student2 upload file to assignment and send it for marking. – As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id={activity_id} &download=zip) – Make sure files uploaded by student 2 are only included in zip – As student 1 send activity for marking – As teacher view submission again and click "Download all assignments as a zip" (mod/assignment/submissions.php?id= {activity_id} &download=zip) – Make sure files from student 1 and student 2 are included in zip.

Description

The problem is with Assignment(2.2)- Advanced uploading of files.

If "Enabled send for marking" button is No, then it is not possible to download submitted assignments as zip.
All submitted assignments are missing the submitted flag from assignment_submissions table data2 field and therefore they are excluded from the zip generator.

I think it should be possible to download the assignment files as zip even when the "Enabled send for marking" button is set No.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-35910_patch.txt
1 kB
11/Oct/12 2:37 AM

Issue Links

is a regression caused by

MDL-30121 Draft files included in zip file from "advanced uploading of files" activity

Closed

is duplicated by

MDL-35912 Download all assignments as a zip is not working

Closed

Activity

People

Assignee:: Rajesh Taneja

Reporter:: Tõnis Tartes

Integrator:: Dan Poltawski

Tester:: Michael de Raadt

Participants:: Anis Jradah, Chris Fryer, Dan Poltawski, Jeff Lyle, Mark Ward, Michael de Raadt, Rajesh Taneja, Tõnis Tartes

Component watchers:: Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 15 Vote for this issue

Watchers:: 11 Start watching this issue

Dates

Created:: 10/Oct/12 3:58 AM

Updated:: 30/Sep/13 9:12 PM

Resolved:: 01/Nov/12 11:03 PM

Fix Release Date:: 12/Nov/12