Details

    • Testing Instructions:
      Hide
      1. Log into Moodle as an administrator.
      2. Visit <yoursite>/admin/purgecaches.php and purge your Moodle cache.
      3. Clear your browser cache.
      4. Visit <yoursite>/user/files.php.
      5. Click on 'Create folder'.
      6. Verify that there is a label for the input field and the label's for attribute matches the id on the input field.
      7. Ensure you can add a folder successfully.
      8. Test in all supported browsers (as this required a JS change).
      Show
      Log into Moodle as an administrator. Visit <yoursite>/admin/purgecaches.php and purge your Moodle cache. Clear your browser cache. Visit <yoursite>/user/files.php. Click on 'Create folder'. Verify that there is a label for the input field and the label's for attribute matches the id on the input field. Ensure you can add a folder successfully. Test in all supported browsers (as this required a JS change).
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull 2.4 Branch:
      MDL-35924_m24
    • Pull Master Branch:
      MDL-35924_master
    • Rank:
      44690

      Description

      Issue
      Forms label - the input field below the new folder name in the create folder modal has no label associated with it.

      Standard Level
      WCAG 2 1.1.1 (A) http://www.w3.org/WAI/WCAG20/quickref/#qr-text-equiv-all

      Impact
      Critical

      Example Link
      http://demo.moodle.net/mod/assign/view.php?id=1778&action=editsubmission

      Test Steps

      1. Login as a student
      2. Navigate to a course
      3. Click the assignment
      4. Click add submissions
      5. Click the create folder button in the file picker with a screen reader one
      6. Notice the screen reader says edit when accessing the input filed in the modal.

        Activity

        Hide
        Damyon Wiese added a comment -

        Thanks Mark - this all looks good.

        [Y] Syntax
        [Y] Output
        [Y] Whitespace
        [Y] Language
        [-] Databases
        [Y] Testing
        [-] Security
        [-] Documentation
        [Y] Git
        [Y] Sanity check

        Sending for integration.

        Show
        Damyon Wiese added a comment - Thanks Mark - this all looks good. [Y] Syntax [Y] Output [Y] Whitespace [Y] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Sending for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
        Hide
        Frédéric Massart added a comment -

        Test passed on 2.3, 2.4 and master using Firefox, Chrome, IE8 and IE9.

        Show
        Frédéric Massart added a comment - Test passed on 2.3, 2.4 and master using Firefox, Chrome, IE8 and IE9.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: