Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35926

Add.. modal allows tab focus to go outside the modal

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note: check tab focus means tab through the dialog and make sure the tab key only focusing on elements within the dialog.

      1. Navigate to My private files.
      2. Create a new folder button. Check tab focus.
      3. Select the create button.
      4. Within the file manager, right click on the folder. Check tab focus.
      5. Click the Add... button in the file picker
      6. Tab through the page and make sure it only select the elements within the modal.
      7. Select different repository and check for tab focus.
      8. click on a file from 'recent files/private files' repository. On select dialog box, check tab focus.

      Additional Test (optional):

      • Repeat the above steps with screenreader on and make sure the screen reader only read elements within the modal.

      Note: This patch doesn't apply for the activity chooser. It is only apply to filemanager and filepicker.

      Show
      Note: check tab focus means tab through the dialog and make sure the tab key only focusing on elements within the dialog. Navigate to My private files. Create a new folder button. Check tab focus. Select the create button. Within the file manager, right click on the folder. Check tab focus. Click the Add... button in the file picker Tab through the page and make sure it only select the elements within the modal. Select different repository and check for tab focus. click on a file from 'recent files/private files' repository. On select dialog box, check tab focus. Additional Test (optional): Repeat the above steps with screenreader on and make sure the screen reader only read elements within the modal. Note: This patch doesn't apply for the activity chooser. It is only apply to filemanager and filepicker.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35926_alt_c
    • Story Points:
      8
    • Sprint:
      FRONTEND Sprint 5

      Description

      Issue
      Context change - When the user activates Add.. modal, the focus is not being put in the modal window but is being sent back to the top of the page. Screen reader and keyboard users now have to make their way back to the modal window, only to find out it's impossible to get back in it (and therefore, close it).

      Standard Level
      WCAG 2 3.2.2 (A) http://www.w3.org/WAI/WCAG20/quickref/#qr-minimize-error-cues

      Impact
      Critical

      Example Link
      http://demo.moodle.net/mod/assign/view.php?id=1778&action=editsubmission

      Test Steps

      1. Login as a student
      2. Navigate to a course
      3. Click the assignment
      4. Click add submissions
      5. Click the Add... button in the file picker with a screen reader one
      6. Notice the screen reader starts reading at the top of the page.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rwijaya Rossiani Wijaya
              Reporter:
              jrh18 Jason Hardin
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Sam Hemelryk
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Barbara Ramiro, Bas Brands
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13