Moodle
  1. Moodle
  2. MDL-35954

New init_select_autosubmit JS function does not update the last option chosen.

    Details

    • Testing Instructions:
      Hide

      This must be tested in all supported browsers as the JS function being changed is used throughout Moodle.

      1. Create a new course with some enrolled students in it.
      2. Create a new assignment with setting 'Feedback settings > Offline grading worksheet' to Yes.
      3. Save and display the assignment.
      4. Log in as a student for that course and submit a file for the assignment.
      5. Go back to your Administrator role and click on 'View/grade all submissions'.
      6. Select 'Download grading worksheet' from the dropdown menu so you are are prompted to download a file.
      7. Click on the drop down box again and make sure you aren't specified to download this file again.
      8. Browse the Moodle site and ensure all drop down boxes are working as expected (adding blocks, navigating in grade book etc).
      Show
      This must be tested in all supported browsers as the JS function being changed is used throughout Moodle. Create a new course with some enrolled students in it. Create a new assignment with setting 'Feedback settings > Offline grading worksheet' to Yes. Save and display the assignment. Log in as a student for that course and submit a file for the assignment. Go back to your Administrator role and click on 'View/grade all submissions'. Select 'Download grading worksheet' from the dropdown menu so you are are prompted to download a file. Click on the drop down box again and make sure you aren't specified to download this file again. Browse the Moodle site and ensure all drop down boxes are working as expected (adding blocks, navigating in grade book etc).
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35954_master

      Description

      When viewing the grades screen for the assignment module and selecting 'Download grading worksheet', you are then prompted to download the file whenever you click on the drop down box again.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Mark Nelson added a comment - - edited

            Hi Damyon, assigning this to you as you have dealt with related issues.

            Show
            Mark Nelson added a comment - - edited Hi Damyon, assigning this to you as you have dealt with related issues.
            Hide
            Mark Nelson added a comment -

            After some investigation it seems this is not an issue with the assignment module, but with the render_url_select function in lib/outputrenderers.php which uses the new JS function init_select_autosubmit in lib/javascript-static.js, rather than the old one used in earlier versions which was init_url_select. I changed the JS function from init_select_autosubmit to init_url_select and this is no longer issue, so it seems the new JS function is cause of the problem.

            Show
            Mark Nelson added a comment - After some investigation it seems this is not an issue with the assignment module, but with the render_url_select function in lib/outputrenderers.php which uses the new JS function init_select_autosubmit in lib/javascript-static.js, rather than the old one used in earlier versions which was init_url_select. I changed the JS function from init_select_autosubmit to init_url_select and this is no longer issue, so it seems the new JS function is cause of the problem.
            Hide
            Andrew Nicols added a comment -

            I believe that this issue should be resolved by MDL-35569 too, but this should probably be applied too because the old function is still callable by third-party code.

            Show
            Andrew Nicols added a comment - I believe that this issue should be resolved by MDL-35569 too, but this should probably be applied too because the old function is still callable by third-party code.
            Hide
            Sam Hemelryk added a comment -

            Thanks Mark, this has been integrated now.

            Andrew thanks for chiming in on this issue.

            Show
            Sam Hemelryk added a comment - Thanks Mark, this has been integrated now. Andrew thanks for chiming in on this issue.
            Hide
            Dan Poltawski added a comment -

            This looks good on Safari.

            Show
            Dan Poltawski added a comment - This looks good on Safari.
            Hide
            Damyon Wiese added a comment -

            This looks good on firefox, chrome, ie8 and ie9.

            Show
            Damyon Wiese added a comment - This looks good on firefox, chrome, ie8 and ie9.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: