Moodle
  1. Moodle
  2. MDL-35959

Incorrect style added to moodle dialogue footer

    Details

    • Rank:
      44718

      Description

      lib/yui/notification/notification.js adds CSS.CONTENT to the footer instead of CSS.FOOTER.
      Additionally, CSS.FOOTER is inconsistent with the standard naming of other similar elements (moodle-dialogue-fd instead of moodle-dialogue-ft).

      These currently aren't used anywhere, but I intend to use them shortly.

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          Once this has been peer reviewed, I'll produce a MOODLE_23_STABLE branch.

          Show
          Andrew Nicols added a comment - Once this has been peer reviewed, I'll produce a MOODLE_23_STABLE branch.
          Hide
          Dan Poltawski added a comment -

          Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..

          Show
          Dan Poltawski added a comment - Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..
          Hide
          Sam Hemelryk added a comment -

          Thanks for picking that up Andrew!
          This has been integrated now, I've also implemented it on 22 and 23.

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Thanks for picking that up Andrew! This has been integrated now, I've also implemented it on 22 and 23. Many thanks Sam
          Hide
          Mark Nelson added a comment -

          I clicked to backup a course, then clicked 'cancel' to view a dialogue box. The footer of the dialogue box has the classes "moodle-dialogue-ft yui3-widget-ft", passing.

          Show
          Mark Nelson added a comment - I clicked to backup a course, then clicked 'cancel' to view a dialogue box. The footer of the dialogue box has the classes "moodle-dialogue-ft yui3-widget-ft", passing.
          Hide
          Dan Poltawski added a comment -

          Hurray!

          You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

          Show
          Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: