[MDL-35959] Incorrect style added to moodle dialogue footer - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.3.2
Fix Version/s: 2.2.6, 2.3.3
Component/s: JavaScript
Labels:
- patch
- triaged

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://git.luns.net.uk/moodle.git
Pull Master Branch:
~~MDL-35959~~-master-1
Pull Master Diff URL:
https://git.luns.net.uk/moodle.git/commitdiff/MDL-35959-master
Testing Instructions:

Hide

Very difficult to test as there's nothing that uses this - at least not in core.

Show
Very difficult to test as there's nothing that uses this - at least not in core.

Description

lib/yui/notification/notification.js adds CSS.CONTENT to the footer instead of CSS.FOOTER.
Additionally, CSS.FOOTER is inconsistent with the standard naming of other similar elements (moodle-dialogue-fd instead of moodle-dialogue-ft).

These currently aren't used anywhere, but I intend to use them shortly.

Attachments

Issue Links

blocks

MDL-35819 Rewrite help popup to use moodle-core-notification and restyle

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Integrator:: Sam Hemelryk

Tester:: Mark Nelson

Participants:: Andrew Lyons, Dan Poltawski, Mark Nelson, Sam Hemelryk

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 11/Oct/12 2:01 AM

Updated:: 01/Nov/12 11:03 PM

Resolved:: 01/Nov/12 11:03 PM

Fix Release Date:: 12/Nov/12