Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35978

Comment system expand/collapse comment doesn't announce a change to the user

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test prerequisites:

      1. Get the jaws/nvda vm. PM me and I'll show you where it lives.
      2. Run jaws on the vm. Please do not use Chromevox as a substitute for Jaws.

      As an admin user:

      1. Go to profile -> Blog entries and create a new entry
      2. Add some comments to the blog entry you created
      3. Now, reload the page. The comments should be collapsed
      4. Tab to the 'Comments (x)' element and confirm that the screen reader says the element is a button and is collapsed.
      5. Hit the space key and confirm that:
        • The comments section expands
        • The screen reader announces the expansion
      6. Close the element using space and confirm that:
        • The section collapses
        • The screen reader announces the collapse
      7. Confirm that the above expand and collapse works using the 'enter' key too.
      8. Now, expand again
      9. Using the down arrow key confirm that you can move through the content (user picture, name, date, close comments box, and the comment text)
      Show
      Test prerequisites : Get the jaws/nvda vm. PM me and I'll show you where it lives. Run jaws on the vm. Please do not use Chromevox as a substitute for Jaws. As an admin user: Go to profile -> Blog entries and create a new entry Add some comments to the blog entry you created Now, reload the page. The comments should be collapsed Tab to the 'Comments (x)' element and confirm that the screen reader says the element is a button and is collapsed. Hit the space key and confirm that: The comments section expands The screen reader announces the expansion Close the element using space and confirm that: The section collapses The screen reader announces the collapse Confirm that the above expand and collapse works using the 'enter' key too. Now, expand again Using the down arrow key confirm that you can move through the content (user picture, name, date, close comments box, and the comment text)
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35978-master
    • Sprint:
      3.3 sprint 2

      Description

      Issue
      Context changes - Expand/collapse of comments are not being announced as opened or closed to screen readers users. It would be useful to rely on aria-live="polite" to tell screen readers if the comments are "live" (opened or closed) or provide another similar mechanism.

      Semantics - The expand/collapse icon for comments should be coded using a <button> element and not a <a> element, as activating them is not leading the user anywhere (as would a link).

      Standard Level
      WCAG 2 3.3.2 (A) http://www.w3.org/TR/UNDERSTANDING-WCAG20/minimize-error-cues.html
      WCAG 2 1.3.1 (A) http://www.w3.org/TR/UNDERSTANDING-WCAG20/content-structure-separation-programmatic.html

      Impact
      Serious
      Serious

      Example Link
      http://accessibility.mroomstest.net/blog/index.php

      Test Steps

      1. Login as user0
      2. Navigate to the link
      3. Expand and collapse the comments area under a blog post

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Mar/17