Details

    • Rank:
      44740

      Description

      Issue
      Short text alternative - The image used to delete the comment needs to be assigned alt

      Standard Level
      WCAG 2 1.1.1 (A) http://www.w3.org/TR/UNDERSTANDING-WCAG20/text-equiv-all.html

      Impact
      Critical

      Example Link
      http://accessibility.mroomstest.net/blog/index.php

      Test Steps

      1. Login as user0
      2. Navigate to the link above
      3. Add a comment
      4. View the source of the delete comment icon and notice the missing alt attribute on the image

        Activity

        Hide
        Michael de Raadt added a comment -

        Or at least an alt that is indicative of the image and not the same as the link title.

        Show
        Michael de Raadt added a comment - Or at least an alt that is indicative of the image and not the same as the link title.
        Hide
        Jason Fowler added a comment -

        Would seem Fred was nice enough to clean this up in the process of adding the new icons for 2.4 - will look at the older versions and make sure it gets cleaned up there to

        Show
        Jason Fowler added a comment - Would seem Fred was nice enough to clean this up in the process of adding the new icons for 2.4 - will look at the older versions and make sure it gets cleaned up there to
        Hide
        Jason Fowler added a comment -

        Ah, I totally misread the issue - I thought the alt attribute was present with text that needed to be removed.

        Show
        Jason Fowler added a comment - Ah, I totally misread the issue - I thought the alt attribute was present with text that needed to be removed.
        Hide
        Adrian Greeve added a comment -

        [Y] Syntax
        [Y] Output
        [-] Whitespace
        [-] Language
        [-] Databases
        [Y] Testing
        [-] Security
        [-] Documentation
        [Y] Git
        [Y] Sanity check

        This looks good. I had a talk to Jason and he explained to me the reason for an empty alt tag. The anchor tag that surrounds the image provides a description for the delete image. The delete image therefore is for decoration.

        http://www.un.org/webaccessibility/1_visual/11_alternativetext.shtml explains:

        If an image does not convey any information and only serves a decorative purpose, add an empty "alt" attribute. Decorative elements can be defined in a CSS style sheet.

        Thanks.

        Show
        Adrian Greeve added a comment - [Y] Syntax [Y] Output [-] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check This looks good. I had a talk to Jason and he explained to me the reason for an empty alt tag. The anchor tag that surrounds the image provides a description for the delete image. The delete image therefore is for decoration. http://www.un.org/webaccessibility/1_visual/11_alternativetext.shtml explains: If an image does not convey any information and only serves a decorative purpose, add an empty "alt" attribute. Decorative elements can be defined in a CSS style sheet. Thanks.
        Hide
        Dan Poltawski added a comment -

        Thanks Jason, i've integrated this now (master, 24, 23 and 22)

        Show
        Dan Poltawski added a comment - Thanks Jason, i've integrated this now (master, 24, 23 and 22)
        Hide
        David Monllaó added a comment -

        It passes, works as expected, tested in 22, 23 and master

        Show
        David Monllaó added a comment - It passes, works as expected, tested in 22, 23 and master
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Changes are now upstream, thanks for your collaboration!

        If you are going to have any celebration next days, enjoy with your gang, if not, too!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Changes are now upstream, thanks for your collaboration! If you are going to have any celebration next days, enjoy with your gang, if not, too! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: