Moodle
  1. Moodle
  2. MDL-36015

E_STRICT errors in lib/bennu

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Critical Critical
        • Resolution: Fixed
        • Affects Version/s: 2.3.2
        • Fix Version/s: 2.3.3
        • Component/s: Calendar
        • Labels:
        • Testing Instructions:
          Hide
          1. Ensure MDL-16660 has been integrated.
          2. Create an iCal subscription.
          3. Check you don't get notices.
          4. Reset the last updated timestamp for your subscription in the database.
          5. Run cron.
          6. Check you don't get notices.
          Show
          Ensure MDL-16660 has been integrated. Create an iCal subscription. Check you don't get notices. Reset the last updated timestamp for your subscription in the database. Run cron. Check you don't get notices.
        • Affected Branches:
          MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
        • Pull Master Diff URL:
        • Rank:
          44774

          Description

          lib/bennu raises E_STRICT errors when calling non-static functions statically, e.g.:

          Strict standards: Non-static method iCalendar_parameter::is_valid_value() should not be called statically, assuming $this from incompatible context in lib/bennu/iCalendar_properties.php on line 48

            Issue Links

            is blocked by

            New Feature - A new Moodle feature which has yet to be developed. MDL-16660 Calendar: IMPORT or Subscribe to iCal feed into Moodle calendar

            • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Jonathan Harker added a comment -

              Potentially blocking MDL-16660 depending on severity.

              Show
              Jonathan Harker added a comment - Potentially blocking MDL-16660 depending on severity.
              Hide
              Permalink
              Jonathan Harker added a comment -

              Fix for master and 2.3 supplied - this commit can also be cherry-picked onto 2.x and 1.9 unaltered.

              Show
              Jonathan Harker added a comment - Fix for master and 2.3 supplied - this commit can also be cherry-picked onto 2.x and 1.9 unaltered.
              Hide
              Permalink
              Michael de Raadt added a comment -

              It would be good if you could add some testing instructions and request a peer review on this.

              Show
              Michael de Raadt added a comment - It would be good if you could add some testing instructions and request a peer review on this.
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Linking MDL-16660, required for testing

              Show
              Sam Hemelryk added a comment - Linking MDL-16660 , required for testing
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Changes look good thanks Jonathan. Putting this up for integration. Providing MDL-16660 lands I think this really needs to land as well.

              Many thanks
              Sam

              Show
              Sam Hemelryk added a comment - Changes look good thanks Jonathan. Putting this up for integration. Providing MDL-16660 lands I think this really needs to land as well. Many thanks Sam
              Hide
              Permalink
              Aparup Banerjee added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              Permalink
              Dan Poltawski added a comment -

              Thanks Jonathan,

              I've integrated this to 23 and master.

              I did look at the rest of the library to see if we need to be updating upstream, but looks long since abandoned.

              Show
              Dan Poltawski added a comment - Thanks Jonathan, I've integrated this to 23 and master. I did look at the rest of the library to see if we need to be updating upstream, but looks long since abandoned.
              Hide
              Permalink
              Mark Nelson added a comment -

              Did not receive any notice messages when I imported an iCal file to my subscriptions, or when I ran the cron. Passing.

              Show
              Mark Nelson added a comment - Did not receive any notice messages when I imported an iCal file to my subscriptions, or when I ran the cron. Passing.
              Hide
              Permalink
              Dan Poltawski added a comment -

              Hurray!

              You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

              Show
              Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

                People

                • Votes:
                  4 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: