XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.4
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      • [-] Open a Course in editing mode
      • [-] Open the Activity Chooser
      • [ ] Confirm that everything works as expected - there should be no elements showing through.
      Show
      [-] Open a Course in editing mode [-] Open the Activity Chooser [ ] Confirm that everything works as expected - there should be no elements showing through.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36022-master

      Description

      When I put the chooserdialogue together, I added a shim to try and work around an issue with YouTube. Turns out the issue was with the way that the YouTube video was integrated, but I forgot to remove the shim.

      I wonder whether this is the shim generating the _createShim() functions we've been seeing in the function trees recently so, since it's not required, I propose we remove it.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Dan Poltawski
              Tester:
              Petr Skoda
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jan/13