Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.4
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      • [-] Open a Course in editing mode
      • [-] Open the Activity Chooser
      • [ ] Confirm that everything works as expected - there should be no elements showing through.
      Show
      [-] Open a Course in editing mode [-] Open the Activity Chooser [ ] Confirm that everything works as expected - there should be no elements showing through.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36022-master

      Description

      When I put the chooserdialogue together, I added a shim to try and work around an issue with YouTube. Turns out the issue was with the way that the YouTube video was integrated, but I forgot to remove the shim.

      I wonder whether this is the shim generating the _createShim() functions we've been seeing in the function trees recently so, since it's not required, I propose we remove it.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            This, added to previous fixes, should help resolve MDL-34328.

            Show
            salvetore Michael de Raadt added a comment - This, added to previous fixes, should help resolve MDL-34328 .
            Hide
            dobedobedoh Andrew Nicols added a comment -

            This will need to be rebased after some other upcoming changes have been integrated, but I can do that post peer-review.

            Show
            dobedobedoh Andrew Nicols added a comment - This will need to be rebased after some other upcoming changes have been integrated, but I can do that post peer-review.
            Hide
            poltawski Dan Poltawski added a comment -

            If you added it, and are sure we don't need it, then this looks fine. [I haven't tested this].

            Show
            poltawski Dan Poltawski added a comment - If you added it, and are sure we don't need it, then this looks fine. [I haven't tested this] .
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Rebased on latest integration so shouldn't be seeing any merge conflicts now.

            Show
            dobedobedoh Andrew Nicols added a comment - Rebased on latest integration so shouldn't be seeing any merge conflicts now.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated this myself since its been waiting around a bit and simple. Thanks Andrew.

            Show
            poltawski Dan Poltawski added a comment - Integrated this myself since its been waiting around a bit and simple. Thanks Andrew.
            Hide
            skodak Petr Skoda added a comment -

            Tested both branches using iframes and other stuff in section description, works fine for me in IE9, Safari, FF and Chrome.

            Thanks.

            Show
            skodak Petr Skoda added a comment - Tested both branches using iframes and other stuff in section description, works fine for me in IE9, Safari, FF and Chrome. Thanks.
            Hide
            poltawski Dan Poltawski added a comment -

            Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

            ciao
            Dan

            Show
            poltawski Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13