Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.4
    • Component/s: AJAX and JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      • [-] Open a Course in editing mode
      • [-] Open the Activity Chooser
      • [ ] Confirm that everything works as expected - there should be no elements showing through.
      Show
      [-] Open a Course in editing mode [-] Open the Activity Chooser [ ] Confirm that everything works as expected - there should be no elements showing through.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36022-master
    • Rank:
      44782

      Description

      When I put the chooserdialogue together, I added a shim to try and work around an issue with YouTube. Turns out the issue was with the way that the YouTube video was integrated, but I forgot to remove the shim.

      I wonder whether this is the shim generating the _createShim() functions we've been seeing in the function trees recently so, since it's not required, I propose we remove it.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          This, added to previous fixes, should help resolve MDL-34328.

          Show
          Michael de Raadt added a comment - This, added to previous fixes, should help resolve MDL-34328 .
          Hide
          Andrew Nicols added a comment -

          This will need to be rebased after some other upcoming changes have been integrated, but I can do that post peer-review.

          Show
          Andrew Nicols added a comment - This will need to be rebased after some other upcoming changes have been integrated, but I can do that post peer-review.
          Hide
          Dan Poltawski added a comment -

          If you added it, and are sure we don't need it, then this looks fine. [I haven't tested this].

          Show
          Dan Poltawski added a comment - If you added it, and are sure we don't need it, then this looks fine. [I haven't tested this] .
          Hide
          Andrew Nicols added a comment -

          Rebased on latest integration so shouldn't be seeing any merge conflicts now.

          Show
          Andrew Nicols added a comment - Rebased on latest integration so shouldn't be seeing any merge conflicts now.
          Hide
          Dan Poltawski added a comment -

          Integrated this myself since its been waiting around a bit and simple. Thanks Andrew.

          Show
          Dan Poltawski added a comment - Integrated this myself since its been waiting around a bit and simple. Thanks Andrew.
          Hide
          Petr Škoda added a comment -

          Tested both branches using iframes and other stuff in section description, works fine for me in IE9, Safari, FF and Chrome.

          Thanks.

          Show
          Petr Škoda added a comment - Tested both branches using iframes and other stuff in section description, works fine for me in IE9, Safari, FF and Chrome. Thanks.
          Hide
          Dan Poltawski added a comment -

          Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

          ciao
          Dan

          Show
          Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: