Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36027

PATCH In attribute, use & rather than & in scorm/localib.php for HTML compliance

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.3.2
    • Fix Version/s: None
    • Component/s: SCORM
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      This fixes some invalid HTML.
      On approximately line #1457 of of mod/scorm/locallib.php are the lines:

      $link = 'a='.$scorm->id.'&scoid='.$sco->id.'&currentorg='.$currentorg.$modestr.'&attempt='.$attempt;
      $result->toc .= '<a title="'.$link.'">'.$statusicon.'&nbsp;'.format_string($sco->title).'&nbsp;'.$score.'</a>';

      Because ampersand introduces an entity (like &gt, ampersand must be escaped in HTML. It should itself represented as
      an entity as it is two lines prior to the problem line. The attached patch does so as follows:

      $link = 'a='.$scorm->id.'&amp;scoid='.$sco->id.'&amp;currentorg='.$currentorg.$modestr.'&amp;attempt='.$attempt;

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              danmarsden Dan Marsden
              Reporter:
              raymor Ray Morris
              Participants:
              Component watchers:
              Damyon Wiese, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: