Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36030

grade item id displays in place of grade value in user report if not showtotalsifcontainhidden

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 2.2.5, 2.3.2, 2.7.12, 2.8.10, 2.9.4, 3.0.2
    • Fix Version/s: None
    • Component/s: Gradebook
    • Testing Instructions:
      Hide
      1. Create a course with an assignment and name it Assignment 1.
      2. Enrol some students and grade the assignment for one of the students as 80%.
      3. Navigate to the course and under Course administration, go to Grade administration ► Setup ► Gradebook setup.
      4. Click Add grade item.
      5. Enter the Item name GI1 and click Save changes
      6. Back on the Gradebook setup page, click the Edit menu of the created grade item and click Edit calculation
      7. Under ID numbers, set the with the ID number for Assignment 1 as assign1 then click Add ID numbers.
      8. Still on the Edit calculation page for GI1, set the Calculation as =[[assign1]] then click Save changes.
      9. Back on the Gradebook setup page, click on the Edit menu of Assignment 1 and click Hide.
      10. Under Grade administration, click Course grade settings.
      11. On the Overview report section, set Hide totals if they contain hidden items to Show totals excluding hidden items.
      12. On the User report section, set Hide totals if they contain hidden items to Show totals excluding hidden items.
      13. Login as the student with the graded assignment and go to the course.
      14. Under Course administration, click Grades.
      15. On the user report for the student,
        • Confirm that Assignment 1 is not being shown.
        • Confirm that GI1 is shown with the proper grade of 80%.
      16. Under Grade administration, click Overview report.
        • Confirm that a grade of 80% is being shown.
      Show
      Create a course with an assignment and name it Assignment 1. Enrol some students and grade the assignment for one of the students as 80%. Navigate to the course and under Course administration, go to Grade administration ► Setup ► Gradebook setup. Click Add grade item . Enter the Item name GI1 and click Save changes Back on the Gradebook setup page, click the Edit menu of the created grade item and click Edit calculation Under ID numbers, set the with the ID number for Assignment 1 as assign1 then click Add ID numbers . Still on the Edit calculation page for GI1 , set the Calculation as =[[assign1]] then click Save changes. Back on the Gradebook setup page, click on the Edit menu of Assignment 1 and click Hide . Under Grade administration, click Course grade settings . On the Overview report section, set Hide totals if they contain hidden items to Show totals excluding hidden items . On the User report section, set Hide totals if they contain hidden items to Show totals excluding hidden items . Login as the student with the graded assignment and go to the course. Under Course administration, click Grades . On the user report for the student, Confirm that Assignment 1 is not being shown. Confirm that GI1 is shown with the proper grade of 80%. Under Grade administration, click Overview report . Confirm that a grade of 80% is being shown.
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      mdl36030-master

      Description

      In at least some cases, if the grade book is set up to not show totals if contains hidden, the grade item id appears in the user report in place of the grade value. That is because of this line in blank_hidden_total:

      $finalgrade = $hiding_affected['unknown'][$course_item->id];

      The values in $hiding_affected['unknown'] are not grades values; they are grade item ids. See implementation of grade_grade::get_hiding_affected:

      $unknown[$do] = $do;

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                7 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: