Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an Assignment
      2. There should be a setting on the module settings page that says "Students submit in groups"
      3. There should be a setting on the module settings page that says "Grouping for student groups"
      4. The help text for the settings should refer to "Group assignment" instead of "Team assignment"
      5. Login as a student who can submit to the assignment, the submission status on the front page of the assignment should have a row for "Group" and not "Team"
      Show
      Create an Assignment There should be a setting on the module settings page that says "Students submit in groups" There should be a setting on the module settings page that says "Grouping for student groups" The help text for the settings should refer to "Group assignment" instead of "Team assignment" Login as a student who can submit to the assignment, the submission status on the front page of the assignment should have a row for "Group" and not "Team"
    • Workaround:
      Hide

      Change this in a custom language pack.

      Show
      Change this in a custom language pack.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      This is more a question than an improvement:

      The assign module uses the term 'team' and 'identifier'. What is meant by these terms?
      Are teams moodle course groups? Than it should be renamed to groups?

        Gliffy Diagrams

        1. groupandgrouping.png
          17 kB
        2. groupstudentview.png
          6 kB
        3. groupsubmission.png
          17 kB

          Activity

          Hide
          ralfh Ralf Hilgenstock added a comment -

          I've seen now that the course related groups and groupings are used for the teams. Than we should use the term 'group' also for assignment groups instead of 'team'. I will do this for German translation now.

          Show
          ralfh Ralf Hilgenstock added a comment - I've seen now that the course related groups and groupings are used for the teams. Than we should use the term 'group' also for assignment groups instead of 'team'. I will do this for German translation now.
          Hide
          salvetore Michael de Raadt added a comment -

          Damyon: Why was the term team used?

          Show
          salvetore Michael de Raadt added a comment - Damyon: Why was the term team used?
          Hide
          damyon Damyon Wiese added a comment -

          I think it was just a historical thing (there is a team assignment plugin for the old assignment module).

          Show
          damyon Damyon Wiese added a comment - I think it was just a historical thing (there is a team assignment plugin for the old assignment module).
          Hide
          salvetore Michael de Raadt added a comment -

          I don't think we can get enough discussion to change this before the code freeze.

          Show
          salvetore Michael de Raadt added a comment - I don't think we can get enough discussion to change this before the code freeze.
          Hide
          damyon Damyon Wiese added a comment -

          Also - using groups/groupings for the teams was a feature added when we wrote the requirements - but the feature already had a name by then. I am happy to change this to group assignment.

          Show
          damyon Damyon Wiese added a comment - Also - using groups/groupings for the teams was a feature added when we wrote the requirements - but the feature already had a name by then. I am happy to change this to group assignment.
          Hide
          salvetore Michael de Raadt added a comment -

          If you can change this to Group assignment still, and you are happy to do so, then you have my +1 to do it.

          I've asked Helen to have a quick look and lend her opinion.

          Show
          salvetore Michael de Raadt added a comment - If you can change this to Group assignment still, and you are happy to do so, then you have my +1 to do it. I've asked Helen to have a quick look and lend her opinion.
          Hide
          tsala Helen Foster added a comment -

          Ralf, thanks for your attention to detail. I'm in agreement with you that the word 'team' should be changed to 'group' wherever it appears in the assignment settings.

          I notice the team/group assignment settings are not mentioned at all in Moodle Docs, so I've added the docs_required label to this issue to ensure it gets done.

          Show
          tsala Helen Foster added a comment - Ralf, thanks for your attention to detail. I'm in agreement with you that the word 'team' should be changed to 'group' wherever it appears in the assignment settings. I notice the team/group assignment settings are not mentioned at all in Moodle Docs, so I've added the docs_required label to this issue to ensure it gets done.
          Hide
          damyon Damyon Wiese added a comment -

          I have kept this change small and only changed this in the language files (not the database column or the language keys). This is because it is not worth adding extra upgrade code to change the database column and at least the database column and the code are all the same.

          Show
          damyon Damyon Wiese added a comment - I have kept this change small and only changed this in the language files (not the database column or the language keys). This is because it is not worth adding extra upgrade code to change the database column and at least the database column and the code are all the same.
          Hide
          marycooch Mary Cooch added a comment - - edited

          I tested this out tonight because I was making a screencast.
          (2) and (3) displayed "groups". I wasn't sure about (4)because the only help text I saw said "group submission" not assignment. (5) also displayed correctly for students. Screenshots attached (hopefully)

          Show
          marycooch Mary Cooch added a comment - - edited I tested this out tonight because I was making a screencast. (2) and (3) displayed "groups". I wasn't sure about (4)because the only help text I saw said "group submission" not assignment. (5) also displayed correctly for students. Screenshots attached (hopefully)
          Hide
          mina Nicolas Martignoni added a comment -

          Will change the french translation adequately too. Thanks to Mary for the heads up.

          Show
          mina Nicolas Martignoni added a comment - Will change the french translation adequately too. Thanks to Mary for the heads up.
          Hide
          marycooch Mary Cooch added a comment -

          Great stuff

          Show
          marycooch Mary Cooch added a comment - Great stuff
          Hide
          damyon Damyon Wiese added a comment -

          Thanks for the screenshots Mary - very helpful.

          Show
          damyon Damyon Wiese added a comment - Thanks for the screenshots Mary - very helpful.
          Hide
          poltawski Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks everyone! This is integrated now

          Show
          poltawski Dan Poltawski added a comment - Thanks everyone! This is integrated now
          Hide
          andyjdavis Andrew Davis added a comment -

          Tested in master. Works as described. Passing.

          Show
          andyjdavis Andrew Davis added a comment - Tested in master. Works as described. Passing.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

          (not really)

          Closing, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!
          Hide
          marycooch Mary Cooch added a comment -

          Removing docs_required label as group assignments are documented here http://docs.moodle.org/24/en/Assignment_settings

          Show
          marycooch Mary Cooch added a comment - Removing docs_required label as group assignments are documented here http://docs.moodle.org/24/en/Assignment_settings

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/12