Moodle
  1. Moodle
  2. MDL-36044

Delete Icon ("X") blocks Score numbers, when in RTL mode (mod/assign , Rubrics editor)

        Details

        • Testing Instructions:
          Hide
          1. Set Moodle to use theme/standard (Should be the default in Moodle 2.4/5/6)
          2. Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs)
          3. Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting)
          4. Navigate into any course
          5. Add a new Moodle 2.3 Assignment (mod/assign) and not the old Moodle 2.2 Assignment
          6. Use the default setting BUT make sure you choose Rubric (advanced grading)
          7. Save the new assignment
          8. Choose "Create a new Rubric"
          9. Add some rubrics (see first attached screen capture)
          10. Make sure the fix enables a clear view of the Rubric's score (see second attached screen capture)
          Show
          Set Moodle to use theme/standard (Should be the default in Moodle 2.4/5/6) Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs) Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting) Navigate into any course Add a new Moodle 2.3 Assignment (mod/assign) and not the old Moodle 2.2 Assignment Use the default setting BUT make sure you choose Rubric (advanced grading) Save the new assignment Choose "Create a new Rubric" Add some rubrics (see first attached screen capture) Make sure the fix enables a clear view of the Rubric's score (see second attached screen capture)
        • Affected Branches:
          MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE, MOODLE_25_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          WIP-MDL-36044-master
        • Pull Master Diff URL:

          Description

          Delete Icon ("X") blocks Score numbers, when in RTL mode (mod/assign , Rubrics editor)

          Delete Icon should be positioned to the left of the Score

            Gliffy Diagrams

            1. bonfire-screenshot-20121014-232600-769.png
              151 kB
            2. bonfire-screenshot-20121014-233523-713.png
              91 kB
            3. int_master.png
              11 kB
            4. Selection_033.png
              15 kB
            5. Selection_035.png
              12 kB
            6. stable_master_overlap.png.png
              11 kB
            7. stable_master.png
              10 kB

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Michael de Raadt added a comment -

              Thanks for reporting that and providing a patch, Nadav.

              Marina: Would you be able to peer review this?

              Show
              Michael de Raadt added a comment - Thanks for reporting that and providing a patch, Nadav. Marina: Would you be able to peer review this?
              Hide
              Permalink
              Marina Glancy added a comment -

              looks fine for me. Thanks

              Show
              Marina Glancy added a comment - looks fine for me. Thanks
              Hide
              Permalink
              Nadav Kavalerchik added a comment -

              @Marina, please see if you can pass it forward

              Show
              Nadav Kavalerchik added a comment - @Marina, please see if you can pass it forward
              Hide
              Permalink
              Nadav Kavalerchik added a comment -

              Rebased over latest 1-11-2012 master branch
              And ready for integration ( I think )

              Show
              Nadav Kavalerchik added a comment - Rebased over latest 1-11-2012 master branch And ready for integration ( I think )
              Hide
              Permalink
              Marina Glancy added a comment -

              Hi Nadav,
              sorry it took long, I was on holidays. Code looks fine to me. Passing.
              Thank you
              Marina

              Show
              Marina Glancy added a comment - Hi Nadav, sorry it took long, I was on holidays. Code looks fine to me. Passing. Thank you Marina
              Hide
              Permalink
              Nadav Kavalerchik added a comment -

              Rebased over latest 12-11-2012 master and Moodle 23 stable branches

              Marina, thanks! Please see if you can change the status and push it forward.

              Show
              Nadav Kavalerchik added a comment - Rebased over latest 12-11-2012 master and Moodle 23 stable branches Marina, thanks! Please see if you can change the status and push it forward.
              Hide
              Permalink
              Marina Glancy added a comment -

              should cherry-pick without problems to all versions (2.4 - master). Thanks

              Show
              Marina Glancy added a comment - should cherry-pick without problems to all versions (2.4 - master). Thanks
              Hide
              Permalink
              Nadav Kavalerchik added a comment -

              Marina Glancy, I have rebased this fix onto latest (16/8/2013) master.
              Moodle 2.3 version is not relevant anymore.
              It's a minor change. I think it can be cherry picked into Moodle 2.4/5 easily.
              Please see if you can move this forward.

              Show
              Nadav Kavalerchik added a comment - Marina Glancy , I have rebased this fix onto latest (16/8/2013) master. Moodle 2.3 version is not relevant anymore. It's a minor change. I think it can be cherry picked into Moodle 2.4/5 easily. Please see if you can move this forward.
              Hide
              Permalink
              Marina Glancy added a comment -

              It's already waiting for integration Nadav. Thanks

              Show
              Marina Glancy added a comment - It's already waiting for integration Nadav. Thanks
              Hide
              Permalink
              Dan Poltawski added a comment -

              Integrated to master, 25 and 24 - thanks Nadav.

              Show
              Dan Poltawski added a comment - Integrated to master, 25 and 24 - thanks Nadav.
              Hide
              Permalink
              Mark Nelson added a comment -

              Ok, so I didn't really see any difference between the two. The 'X' rendered on the next line below the number of points in both cases. I have attached two screenshots.

              Show
              Mark Nelson added a comment - Ok, so I didn't really see any difference between the two. The 'X' rendered on the next line below the number of points in both cases. I have attached two screenshots.
              Hide
              Permalink
              Mark Nelson added a comment -

              The first two screenshots are taken in <= Moodle 2.3 where this was an issue but it no longer seems to be. However, in stable master (note: not integration) the 'x' appears outside of the box (screenshot attached). I am not sure if this issue resolves that or if it's another.

              Show
              Mark Nelson added a comment - The first two screenshots are taken in <= Moodle 2.3 where this was an issue but it no longer seems to be. However, in stable master (note: not integration) the 'x' appears outside of the box (screenshot attached). I am not sure if this issue resolves that or if it's another.
              Hide
              Permalink
              Nadav Kavalerchik added a comment -

              Mark Nelson, It seems you are testing it on theme/clean. Were this issue was actually relates to theme/standard.
              I should have been more clear in the test instruction. (updated)

              Last developer meeting I asked Martin if theme/clean is the new standard theme in Moodle 2.5/6 and the answer was: No.

              Obviously, It should also look good on theme/clean. but it was originally meant for theme/standard.

              Show
              Nadav Kavalerchik added a comment - Mark Nelson , It seems you are testing it on theme/clean. Were this issue was actually relates to theme/standard. I should have been more clear in the test instruction. (updated) Last developer meeting I asked Martin if theme/clean is the new standard theme in Moodle 2.5/6 and the answer was: No. Obviously, It should also look good on theme/clean. but it was originally meant for theme/standard.
              Hide
              Permalink
              Mark Nelson added a comment -

              Hi Nadav, I attached two more screenshots in master comparing stable to integration using the standard theme and did not see any differences. Am I missing something?

              Show
              Mark Nelson added a comment - Hi Nadav, I attached two more screenshots in master comparing stable to integration using the standard theme and did not see any differences. Am I missing something?
              Hide
              Permalink
              Nadav Kavalerchik added a comment -

              Hi Mark, You are right. I have just tested it and the fix seem irrelevant any more. It might have been useful for long time ago, with Moodle version 2.3 and master branch at that time.)

              Thank you for all your time, testing this issue!

              I am closing it.

              Show
              Nadav Kavalerchik added a comment - Hi Mark, You are right. I have just tested it and the fix seem irrelevant any more. It might have been useful for long time ago, with Moodle version 2.3 and master branch at that time.) Thank you for all your time, testing this issue! I am closing it.
              Hide
              Permalink
              Dan Poltawski added a comment -

              Revverting and reopening this then

              Show
              Dan Poltawski added a comment - Revverting and reopening this then
              Hide
              Permalink
              CiBoT added a comment -

              Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

              Show
              CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
              Hide
              Permalink
              Mark Nelson added a comment -

              Closing this as it is not a bug in any of the supported versions (Only security issues are pushed into 2.3). As Nadav said, it was when this issue was created but is not now.

              Show
              Mark Nelson added a comment - Closing this as it is not a bug in any of the supported versions (Only security issues are pushed into 2.3). As Nadav said, it was when this issue was created but is not now.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: