Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Rank:
      44814

      Description

      cache/README.md need updating urgently.

        Activity

        Hide
        Michael de Raadt added a comment -

        Good work on the MUC, Sam.

        Here are some corrections for this readme file.

        Line 30 Unnecessary 'a'
        Line 39 Unnecessary 'from'
        Line 48 Comma needed after 'definition'
        Line 53 Perhaps a better title would be 'Cache API parts'
        Line 61 'about' should be 'in'
        Line 62 Unnecessary comma after 'make'
        Line 63 This sentence doesn't make sense to me.
        Line 65 'get with a' should be 'get a'
        Line 66 'get' should be 'is' and 'things' should be 'arguments' or 'objects'
        Line 68 Comma needed after 'If it loads data'
        Line 69 Unnecessary comma after 'session'
        Line 70 'adhoc' should be 'ad hoc'
        Line 71 The acronym 'TTL' should be expanded, at least in its initial instance
        Line 85 Comma needed after 'required'
        Line 91 'ensure' should be 'ensures'; perhaps 'about it.' could be 'about its inner workings.'
        Line 94 'adhoc' should be 'ad hoc'
        Line 100 'Application, session, request' should be 'Application, session or request'
        Line 106 'on' should be 'one'
        Line 115 'its' should be 'it's'; comma needed after 'read'
        Line 119 Commas needed before and after 'or retrieved from'
        Line 115 'Its' should be 'It's'; 'but' needed before 'bad'
        Line 135 We probably don't need 'if you can'
        Line 170 'behind the scenes' should be 'behind-the-scenes'
        Line 191 Unnecessary 'from'
        Line 194 'therefor' should be 'therefore'; commas needed before and after 'and therefore'
        Show
        Michael de Raadt added a comment - Good work on the MUC, Sam. Here are some corrections for this readme file. Line 30 Unnecessary 'a' Line 39 Unnecessary 'from' Line 48 Comma needed after 'definition' Line 53 Perhaps a better title would be 'Cache API parts' Line 61 'about' should be 'in' Line 62 Unnecessary comma after 'make' Line 63 This sentence doesn't make sense to me. Line 65 'get with a' should be 'get a' Line 66 'get' should be 'is' and 'things' should be 'arguments' or 'objects' Line 68 Comma needed after 'If it loads data' Line 69 Unnecessary comma after 'session' Line 70 'adhoc' should be 'ad hoc' Line 71 The acronym 'TTL' should be expanded, at least in its initial instance Line 85 Comma needed after 'required' Line 91 'ensure' should be 'ensures'; perhaps 'about it.' could be 'about its inner workings.' Line 94 'adhoc' should be 'ad hoc' Line 100 'Application, session, request' should be 'Application, session or request' Line 106 'on' should be 'one' Line 115 'its' should be 'it's'; comma needed after 'read' Line 119 Commas needed before and after 'or retrieved from' Line 115 'Its' should be 'It's'; 'but' needed before 'bad' Line 135 We probably don't need 'if you can' Line 170 'behind the scenes' should be 'behind-the-scenes' Line 191 Unnecessary 'from' Line 194 'therefor' should be 'therefore'; commas needed before and after 'and therefore'
        Hide
        Sam Hemelryk added a comment -

        Thanks Michael, I've tidied up the grammar+typos there and have pushed this up for integration now.

        Show
        Sam Hemelryk added a comment - Thanks Michael, I've tidied up the grammar+typos there and have pushed this up for integration now.
        Hide
        Dan Poltawski added a comment -

        There is a change in lib/db/caches.php, which isn't strictly related to the README file, but looks like its unused old definiton so pushing this through anyway.

        Show
        Dan Poltawski added a comment - There is a change in lib/db/caches.php, which isn't strictly related to the README file, but looks like its unused old definiton so pushing this through anyway.
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks Sam.

        Show
        Dan Poltawski added a comment - Integrated, thanks Sam.
        Hide
        Dan Poltawski added a comment -

        Hurray!

        You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

        Show
        Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: