Moodle
  1. Moodle
  2. MDL-36069

Right align TEXTAREA "Format selector" listbox, when in RTL mode (theme/standard)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, Future Dev
    • Fix Version/s: 2.3.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs)
      2. Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting)
      3. In your user profile, disable the html editor (to ensure that the 'format chooser' in long text fields)
      4. Navigate into any "Form page" like the course setting page or the User's profile page
      5. Make sure the Format chooser is properly aligned to the right on text fields
      Show
      Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home / ► Site administration / ► Language / ► Language packs) Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting) In your user profile, disable the html editor (to ensure that the 'format chooser' in long text fields) Navigate into any "Form page" like the course setting page or the User's profile page Make sure the Format chooser is properly aligned to the right on text fields
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      WIP-MDL-36069-master
    • Rank:
      44832

      Description

      TEXTAREA form fields that have no pre defined "display format", come with an adjacent "format chooser" listbox field immediately after the textarea field.

      It should be right aligned in RTL mode.

      I have no idea how to switch back to a state in which the "format chooser" can be displayed, if you are already in "HTML Format" mode.
      So if you are testing this patch, try to find a page in Moodle that still has its textarea format unset.

      I have removed an entire RTL CSS rule which was added in the past by me (probably) and i have tested several "Form pages" to see that nothing breaks, and found no regression. so I am not sure what that CSS rule was doing there in the first place. and I hope this fix does not introduce any regressions in any of the "Form pages"

        Activity

        Hide
        Aparup Banerjee added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Nadav Kavalerchik added a comment -

        Rebased on latest master (19-10-2012)

        Show
        Nadav Kavalerchik added a comment - Rebased on latest master (19-10-2012)
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Nadav Kavalerchik added a comment -

        Rebased on latest master (1-11-2012)
        And ready for integration

        Show
        Nadav Kavalerchik added a comment - Rebased on latest master (1-11-2012) And ready for integration
        Hide
        Dan Poltawski added a comment -

        Thanks Nadav, i've integrated this now.

        I updated the testing instructions to disable the html editor, this is how you can consistently get the format chooser to display.

        Show
        Dan Poltawski added a comment - Thanks Nadav, i've integrated this now. I updated the testing instructions to disable the html editor, this is how you can consistently get the format chooser to display.
        Hide
        Frédéric Massart added a comment -

        Test passed on 2.3 and master. Thanks!

        Show
        Frédéric Massart added a comment - Test passed on 2.3 and master. Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

        (not really)

        Closing, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: