[MDL-36092] Impossible to add resource/activities when JS turned off - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.3.2
Fix Version/s: 2.3.3
Component/s: Course
Labels:
- hackfest
- patch
- triaged

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://git.luns.net.uk/moodle.git
Pull Master Branch:
~~MDL-36092~~-master
Pull Master Diff URL:
https://git.luns.net.uk/moodle.git/commitdiff/MDL-36092-master
Testing Instructions:
Hide

[-] Open a course

[-] Turn editing mode on

[-] Disable the Activity chooser from the 'Course settings' menu in the 'Settings' block

[ ] Confirm that the 'Add an activity or resource' link is not shown and that the dropdown pickers are shown

[-] Disable JavaScript in your browser and refresh the page

[ ] Confirm that the 'Add an activity or resource' link is not shown and that the dropdown pickers are shown

[-] Re-enable JavaScript in your browser and refresh the page

[-] Re-enable the Activity chooser

[ ] Confirm that the 'Add an activity or resource' link is shown

[-] Disable JavaScript in your browser and refresh the page

[ ] Confirm that the 'Add an activity or resource' link is not shown and that the dropdown pickers are shown

[-] Re-enable JavaScript in your browser and refresh the page

[ ] Confirm that the 'Add an activity or resource' link is shown
Show
[-] Open a course [-] Turn editing mode on [-] Disable the Activity chooser from the 'Course settings' menu in the 'Settings' block [ ] Confirm that the 'Add an activity or resource' link is not shown and that the dropdown pickers are shown [-] Disable JavaScript in your browser and refresh the page [ ] Confirm that the 'Add an activity or resource' link is not shown and that the dropdown pickers are shown [-] Re-enable JavaScript in your browser and refresh the page [-] Re-enable the Activity chooser [ ] Confirm that the 'Add an activity or resource' link is shown [-] Disable JavaScript in your browser and refresh the page [ ] Confirm that the 'Add an activity or resource' link is not shown and that the dropdown pickers are shown [-] Re-enable JavaScript in your browser and refresh the page [ ] Confirm that the 'Add an activity or resource' link is shown

Description

When the activity chooser is disabled and then Javascript is disabled, then the dropdown menus to add activities/resources to a course are not displayed.

See Marina's comment on ~~MDL-35339~~: http://tracker.moodle.org/browse/MDL-35339?focusedCommentId=183784&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-183784

Replication steps:

Log in as teacher/admin
Navigate to a course
In the Settings block under Course admin, click "Activity Chooser off"
Disable JS in your browser
Refresh the page

Expected result: The "Add a resource..." and "Add an activity..." drop-down lists should appear

Actual results: The link to the Activity chooser appears, but is inactive.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Screen Shot 2012-10-23 at 5.24.38 PM.png
33 kB
23/Oct/12 5:52 PM

Issue Links

Testing discovered

MDL-35339 Improvements to course-related functions

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Frédéric Massart

Peer reviewer:: Frédéric Massart

Integrator:: Dan Poltawski

Tester:: Adrian Greeve

Participants:: Adrian Greeve, Andrew Lyons, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Michael de Raadt

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 17/Oct/12 8:16 PM

Updated:: 10/Nov/12 9:11 AM

Resolved:: 10/Nov/12 9:11 AM

Fix Release Date:: 12/Nov/12