Moodle
  1. Moodle
  2. MDL-36099

yui_module lets you specify a null $galleryversion

    Details

    • Testing Instructions:
      Hide

      Not really sure how best to test this. I guess just check that things are working as expected. I suggest using a course in editing mode and trying things like:

      • ensure that the activity chooser works
      • ensure that you can drag/drop blocks
      • ensure that you can drag/drop resources
      • ensure that you can drag/drop sections
      • ensure that you can show/hide resources and sections
      • ensure that you can rename a file
      Show
      Not really sure how best to test this. I guess just check that things are working as expected. I suggest using a course in editing mode and trying things like: ensure that the activity chooser works ensure that you can drag/drop blocks ensure that you can drag/drop resources ensure that you can drag/drop sections ensure that you can show/hide resources and sections ensure that you can rename a file
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36099-master
    • Rank:
      44861

      Description

      I noticed whilst writing a proof of concept that when calling $PAGE->requires->yui_module(), if you want to set the $ondomready argument, you must specify the $galleryversion. As a result, there are occasions where this is set to null. As a result, we're using a null gallery version rather than a default.

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          For the most part, this probably doesn't matter, but there may be occasions where it does.

          The locations that I found where this was an issue were the calls in course/lib.php which load:

          • lib/yui/blocks/blocks.js
          • course/yui/dragdrop/dragdrop.js

          These can be found by turning on editing mode on a course.

          Show
          Andrew Nicols added a comment - For the most part, this probably doesn't matter, but there may be occasions where it does. The locations that I found where this was an issue were the calls in course/lib.php which load: lib/yui/blocks/blocks.js course/yui/dragdrop/dragdrop.js These can be found by turning on editing mode on a course.
          Hide
          Andrew Nicols added a comment -

          Adding skodak as a watcher as he's probably the person most familiar with galleryversion and what it does.

          Show
          Andrew Nicols added a comment - Adding skodak as a watcher as he's probably the person most familiar with galleryversion and what it does.
          Hide
          Petr Škoda added a comment -

          +10, it is not used anywhere but I thought about the same change when I saw this code myself

          Show
          Petr Škoda added a comment - +10, it is not used anywhere but I thought about the same change when I saw this code myself
          Hide
          Andrew Nicols added a comment -

          Taking Petr's +10 as a positive Peer Review

          Show
          Andrew Nicols added a comment - Taking Petr's +10 as a positive Peer Review
          Hide
          Aparup Banerjee added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Integrated to master. Thanks Andrew

          Show
          Dan Poltawski added a comment - Integrated to master. Thanks Andrew
          Hide
          Frédéric Massart added a comment -

          Test passed. Also I noticed an inconsistency while hiding a section.

          • Hide a section: activities' eyes are opened
          • Show the section: activities' eyes are closed
          • Hide the section: activities' eyes are closed

          I don't think the hide value of the activities are wrong, just they way it is displayed after the ajax call.

          Show
          Frédéric Massart added a comment - Test passed. Also I noticed an inconsistency while hiding a section. Hide a section: activities' eyes are opened Show the section: activities' eyes are closed Hide the section: activities' eyes are closed I don't think the hide value of the activities are wrong, just they way it is displayed after the ajax call.
          Hide
          Dan Poltawski added a comment -

          Hurray!

          You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

          Show
          Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: