Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36105

Inconsistent icon classes in the gradebook

    Details

    • Testing Instructions:
      Hide
      1. Turn on Theme Designer.
      2. Set Afterburner as the site theme.
      3. Access a course gradebook. Go to Categories and Items > Simple view.
      4. Toggle something hide/show. Verify that the hide/show icon sizes are consistent.
      5. Set Formal White as the site theme (bug is not present in Formal White).
      6. Access a course gradebook. Go to Categories and Items > Simple view.
      7. Toggle something hide/show. Verify that the hide/show icon sizes are consistent.
      Show
      Turn on Theme Designer. Set Afterburner as the site theme. Access a course gradebook. Go to Categories and Items > Simple view. Toggle something hide/show. Verify that the hide/show icon sizes are consistent. Set Formal White as the site theme (bug is not present in Formal White). Access a course gradebook. Go to Categories and Items > Simple view. Toggle something hide/show. Verify that the hide/show icon sizes are consistent.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36105-master

      Description

      The icons in the "Categories and Items" report are styled with two different classes. Edit Calculation, Lock Course Total, and Hide Course Total are all styled "smallicon" while Show Course Total is styled "iconsmall." Some themes (like Afterburner) treat these classes differently so you wind up with inconsistent presentation. I've attached a screenshot showing the problem.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            cfulton Charles Fulton added a comment -

            Note that the left-most icon is smaller because it's only 11px. The CSS difference is between the second and third icons.

            Show
            cfulton Charles Fulton added a comment - Note that the left-most icon is smaller because it's only 11px. The CSS difference is between the second and third icons.
            Hide
            cfulton Charles Fulton added a comment -

            Pull request and testing instructions.

            Show
            cfulton Charles Fulton added a comment - Pull request and testing instructions.
            Hide
            fred Frédéric Massart added a comment -

            Thanks Charles, this looks good for integration. Cheers!

            Show
            fred Frédéric Massart added a comment - Thanks Charles, this looks good for integration. Cheers!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Charles, this has been integrated now

            Noting I backported to 22 and 23 as well.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Charles, this has been integrated now Noting I backported to 22 and 23 as well.
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested on the 2.2, 2.3 and master integration branches.
            The icons in the afterburner theme are now the same size.
            No problems found.
            Test passed.

            Show
            abgreeve Adrian Greeve added a comment - Tested on the 2.2, 2.3 and master integration branches. The icons in the afterburner theme are now the same size. No problems found. Test passed.
            Hide
            poltawski Dan Poltawski added a comment -

            Hurray!

            You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

            Show
            poltawski Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12