Moodle

Cache API - typo's and other trivial non-descript cleanup

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.4
  • Component/s: Caching
  • Labels:

Description

A few small obvious things to fix up. Big thanks to Fred for looking over the code to find these!

Issue Links

has been marked as being related by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36359 Typo in cache/admin.php

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Frédéric Massart added a comment -

Noticed this as well. Just an argument which is never used because not set:

diff --git a/cache/classes/factory.php b/cache/classes/factory.php
index 729a46b..32415fc 100644
--- a/cache/classes/factory.php
+++ b/cache/classes/factory.php
@@ -135,7 +135,7 @@ class cache_factory {
         }
         $definition = $this->create_definition($component, $area, $aggregate);
         $definition->set_identifiers($identifiers);
-        $cache = $this->create_cache($definition, $identifiers);
+        $cache = $this->create_cache($definition);
         if ($definition->should_be_persistent()) {
             $this->cachesfromdefinitions[$definitionname] = $cache;
         }
Show
Frédéric Massart added a comment - Noticed this as well. Just an argument which is never used because not set: diff --git a/cache/classes/factory.php b/cache/classes/factory.php index 729a46b..32415fc 100644 --- a/cache/classes/factory.php +++ b/cache/classes/factory.php @@ -135,7 +135,7 @@ class cache_factory { } $definition = $this->create_definition($component, $area, $aggregate); $definition->set_identifiers($identifiers); - $cache = $this->create_cache($definition, $identifiers); + $cache = $this->create_cache($definition); if ($definition->should_be_persistent()) { $this->cachesfromdefinitions[$definitionname] = $cache; }
Hide
Permalink
Sam Hemelryk added a comment -

Putting this up for integration now.

Show
Sam Hemelryk added a comment - Putting this up for integration now.
Hide
Permalink
Dan Poltawski added a comment -

Integrated, thanks Sam

Show
Dan Poltawski added a comment - Integrated, thanks Sam
Hide
Permalink
Dan Poltawski added a comment -

Looks good.

Show
Dan Poltawski added a comment - Looks good.
Hide
Permalink
Matteo Scaramuccia added a comment -

What about adding an extra commit to remove ;; in cache/?

# find cache/ -type f -name '*.php' -exec grep -H -n -E ';;$' {} \; | sort
cache/classes/dummystore.php:267:        return $cache;;
cache/stores/mongodb/lib.php:242:        return false;;
cache/stores/static/lib.php:363:        return $cache;;

(More in MDL-36357)

Show
Matteo Scaramuccia added a comment - What about adding an extra commit to remove ;; in cache/ ? # find cache/ -type f -name '*.php' -exec grep -H -n -E ';;$' {} \; | sort cache/classes/dummystore.php:267: return $cache;; cache/stores/mongodb/lib.php:242: return false;; cache/stores/static/lib.php:363: return $cache;; (More in MDL-36357 )
Hide
Permalink
Dan Poltawski added a comment -

Matteo, thanks! I have done a quick commit to remove those new ones, since you pointed them out.

Show
Dan Poltawski added a comment - Matteo, thanks! I have done a quick commit to remove those new ones, since you pointed them out.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Many, many thanks for your effort!

Millions of people will enjoy the results of your work, yay!

Closing as fixed. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Many, many thanks for your effort! Millions of people will enjoy the results of your work, yay! Closing as fixed. Ciao

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: