Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36115

Cache admin interface shows add instance link for cache stores you can't add

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide
      1. Requires a site without either the Memcache or MemcacheD PHP extensions installed.
      2. Log in as an admin
      3. Browse to Settings > Plugins > Caching
      4. Check that the file store shows an add instance link.
      5. Check that the memcache store does not show an add instance link.
      Show
      Requires a site without either the Memcache or MemcacheD PHP extensions installed. Log in as an admin Browse to Settings > Plugins > Caching Check that the file store shows an add instance link. Check that the memcache store does not show an add instance link.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-36115-m24

      Description

      The admin interface shows an add instance link for a cache store if the user has the required capabilities but doesn't take into account whether the plugin requirements have been met.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            samhemelryk Sam Hemelryk added a comment -

            Up for peer-review.

            Show
            samhemelryk Sam Hemelryk added a comment - Up for peer-review.
            Hide
            poltawski Dan Poltawski added a comment -

            Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..

            Show
            poltawski Dan Poltawski added a comment - Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..
            Hide
            poltawski Dan Poltawski added a comment -

            I've integrated this now, thanks Sam

            Show
            poltawski Dan Poltawski added a comment - I've integrated this now, thanks Sam
            Hide
            abgreeve Adrian Greeve added a comment -

            I don't have Memcache installed on my machine. So I did a comparison of master and integration. It's easy to spot the different. The Add instance link is no longer present.
            Test passed.

            Show
            abgreeve Adrian Greeve added a comment - I don't have Memcache installed on my machine. So I did a comparison of master and integration. It's easy to spot the different. The Add instance link is no longer present. Test passed.
            Hide
            poltawski Dan Poltawski added a comment -

            Hurray!

            You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

            Show
            poltawski Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12